Skip to content

chore(member merge): clean up users without email addresses#101981

Merged
mifu67 merged 4 commits intomasterfrom
mifu67/member-merge/clean-up-users-without-emails-self-hosted
Feb 3, 2026
Merged

chore(member merge): clean up users without email addresses#101981
mifu67 merged 4 commits intomasterfrom
mifu67/member-merge/clean-up-users-without-emails-self-hosted

Conversation

@mifu67
Copy link
Contributor

@mifu67 mifu67 commented Oct 23, 2025

Duplicate of https://github.com/getsentry/getsentry/pull/17549 using a migration for self-hosted users.

@mifu67 mifu67 requested review from a team as code owners October 23, 2025 00:22
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 23, 2025
@mifu67 mifu67 changed the base branch from master to mifu67/member-merge/sentry-app-proxy-user-email-backfill-self-hosted October 23, 2025 00:22

@control_silo_test
@override_settings(SENTRY_SELF_HOSTED=True)
class BackfillSelfHostedSentryAppEmailsTest(TestMigrations):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Test Class Name Mismatch

The test class BackfillSelfHostedSentryAppEmailsTest has an incorrect name. This looks like a copy-paste from the 0997 migration test. The class is actually validating the 0998 migration, which deletes never-active users without emails, so the current name doesn't accurately reflect its purpose.

Fix in Cursor Fix in Web

@getsantry
Copy link
Contributor

getsantry bot commented Nov 20, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Nov 20, 2025
@mifu67 mifu67 removed the Stale label Nov 20, 2025
@getsantry
Copy link
Contributor

getsantry bot commented Dec 12, 2025

This pull request has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you add the label WIP, I will leave it alone unless WIP is removed ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Dec 12, 2025
@getsantry getsantry bot closed this Dec 20, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Jan 4, 2026
@mifu67 mifu67 reopened this Jan 6, 2026
@mifu67 mifu67 changed the base branch from mifu67/member-merge/sentry-app-proxy-user-email-backfill-self-hosted to master January 6, 2026 23:35
@mifu67 mifu67 force-pushed the mifu67/member-merge/clean-up-users-without-emails-self-hosted branch from 38f4381 to 2a0b17e Compare January 6, 2026 23:46
@mifu67 mifu67 enabled auto-merge (squash) January 6, 2026 23:47
@getsantry getsantry bot removed the Stale label Jan 7, 2026
@getsantry getsantry bot added the Stale label Jan 29, 2026
@mifu67 mifu67 merged commit 7e1f2f1 into master Feb 3, 2026
72 of 73 checks passed
@mifu67 mifu67 deleted the mifu67/member-merge/clean-up-users-without-emails-self-hosted branch February 3, 2026 01:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants