Skip to content

fix(aci): fix email/slug fetching if target is None#102256

Merged
mifu67 merged 2 commits into
masterfrom
mifu67/aci/trigger-action-fix
Oct 28, 2025
Merged

fix(aci): fix email/slug fetching if target is None#102256
mifu67 merged 2 commits into
masterfrom
mifu67/aci/trigger-action-fix

Conversation

@mifu67

@mifu67 mifu67 commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

Correct the logic mistake that I introduced in the last pull request.

@mifu67 mifu67 requested a review from a team October 28, 2025 20:48
@mifu67 mifu67 requested a review from a team as a code owner October 28, 2025 20:49
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 28, 2025
@kcons kcons self-requested a review October 28, 2025 20:49

@kcons kcons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about the '[removed]' convention. Also, I'm kinda excited to see that Seer was right.

cursor[bot]

This comment was marked as outdated.

@codecov

codecov Bot commented Oct 28, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...endpoints/serializers/alert_rule_trigger_action.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #102256      +/-   ##
===========================================
+ Coverage   77.39%    80.95%   +3.56%     
===========================================
  Files        8767      8769       +2     
  Lines      389586    389627      +41     
  Branches    24778     24778              
===========================================
+ Hits       301503    315435   +13932     
+ Misses      87705     73814   -13891     
  Partials      378       378              

@mifu67 mifu67 merged commit f9f0b78 into master Oct 28, 2025
69 checks passed
@mifu67 mifu67 deleted the mifu67/aci/trigger-action-fix branch October 28, 2025 21:26
priscilawebdev pushed a commit that referenced this pull request Oct 29, 2025
Correct the logic mistake that I introduced in the last pull request.
shashjar pushed a commit that referenced this pull request Nov 4, 2025
Correct the logic mistake that I introduced in the last pull request.
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants