feat(search-bar): Add conditionals section to filter key dropdown #102314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/u/1396951?s=60&v=4){kind=small}
static/app/components/searchQueryBuilder/tokens/filterKeyListBox/useFilterKeyListBox.tsx
Show resolved
Hide resolved
nsdeschenes
force-pushed
the
nd/exp-562/feat-add-conditionals-section-to-filter-key-dropdown
branch
from
e5e8aaa to
4dd870b
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
static/app/components/searchQueryBuilder/tokens/filterKeyListBox/useFilterKeyListBox.tsx
Show resolved
Hide resolved
malwilley
reviewed
Oct 29, 2025
Member
malwilley
left a comment
malwilley
left a comment
There was a problem hiding this comment.
Should and/or be searchable? it looks like they are not right now
| }): BooleanFilterItem { | ||
| return { | ||
| key: getEscapedKey(value), | ||
| type: 'boolean-filter' as const, |
Member
There was a problem hiding this comment.
nit: AND/OR are technically not filters, which does confuse the naming of the FilterKeyListBox a bit :/
static/app/components/searchQueryBuilder/tokens/filterKeyListBox/utils.tsx
Outdated
Show resolved
Hide resolved
static/app/components/searchQueryBuilder/tokens/filterKeyListBox/types.tsx
Outdated
Show resolved
Hide resolved
Contributor
Author
There is another ticket to handle this, wanted to split the implementations up. |
nsdeschenes
force-pushed
the
nd/exp-562/feat-add-conditionals-section-to-filter-key-dropdown
branch
from
4dd870b to
716ce93
Compare
nsdeschenes
force-pushed
the
nd/exp-562/feat-add-conditionals-section-to-filter-key-dropdown
branch
from
4a74f17 to
644f709
Compare
malwilley
approved these changes
Nov 13, 2025
nsdeschenes
force-pushed
the
nd/exp-562/feat-add-conditionals-section-to-filter-key-dropdown
branch
from
644f709 to
a4d3b53
Compare
nsdeschenes
force-pushed
the
nd/exp-562/feat-add-conditionals-section-to-filter-key-dropdown
branch
from
a4d3b53 to
b20c764
Compare
nsdeschenes
deleted the
nd/exp-562/feat-add-conditionals-section-to-filter-key-dropdown
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in a new
Conditionalssection that containsANDandOR. We conditionally render this section, once the user has moved off of the first item as you can not start a filter with a conditional.Ticket: EXP-562
Example: