-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(issues): Display resolved via integration in activity #102362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
displays integration activity information if the activity came from an activity
| ) : null; | ||
| const viaIntegration = hasIntegration | ||
| ? tct(' via [integration]', {integration: integrationLink}) | ||
| : ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Incomplete Integration Validation Causes Broken Links
The hasIntegration check only verifies integration_id, but provider_key and provider are also needed for a valid integration link and are optional. If these are missing, the integration link will be malformed with "undefined" in the URL and text, leading to broken links.
| title: t('Resolved'), | ||
| message: tct('by [author] in releases greater than [version] [semver]', { | ||
| message: tct( | ||
| 'by [author] in releases greater than [version] [semver][viaIntegration]', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to do by [author] in releases greater than [version] [semver] via [ingregration] instead? That should translate better. Requires you to duplicate the message, but I think that's technically the correct way to do it
displays integration activity information if the activity came from an activity <img width="505" height="75" alt="image" src="https://github.com/user-attachments/assets/f3d65394-a831-455f-ae1d-c0e44690981b" /> part of #102234
displays integration activity information if the activity came from an activity <img width="505" height="75" alt="image" src="https://github.com/user-attachments/assets/f3d65394-a831-455f-ae1d-c0e44690981b" /> part of #102234
displays integration activity information if the activity came from an activity
part of #102234