Skip to content

Conversation

@scttcper
Copy link
Member

@scttcper scttcper commented Oct 29, 2025

displays integration activity information if the activity came from an activity

image

part of #102234

displays integration activity information if the activity came from an activity
@scttcper scttcper requested a review from a team October 29, 2025 21:28
@scttcper scttcper requested a review from a team as a code owner October 29, 2025 21:28
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Oct 29, 2025
) : null;
const viaIntegration = hasIntegration
? tct(' via [integration]', {integration: integrationLink})
: '';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Incomplete Integration Validation Causes Broken Links

The hasIntegration check only verifies integration_id, but provider_key and provider are also needed for a valid integration link and are optional. If these are missing, the integration link will be malformed with "undefined" in the URL and text, leading to broken links.

Fix in Cursor Fix in Web

@scttcper scttcper changed the title feat(issues): Display resolution integration info feat(issues): Display resolved via integration in activity Oct 29, 2025
title: t('Resolved'),
message: tct('by [author] in releases greater than [version] [semver]', {
message: tct(
'by [author] in releases greater than [version] [semver][viaIntegration]',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to do by [author] in releases greater than [version] [semver] via [ingregration] instead? That should translate better. Requires you to duplicate the message, but I think that's technically the correct way to do it

@scttcper scttcper merged commit aee9e10 into master Oct 29, 2025
46 checks passed
@scttcper scttcper deleted the scttcper/activity-integration-info branch October 29, 2025 23:24
shashjar pushed a commit that referenced this pull request Nov 4, 2025
displays integration activity information if the activity came from an
activity

<img width="505" height="75" alt="image"
src="https://github.com/user-attachments/assets/f3d65394-a831-455f-ae1d-c0e44690981b"
/>

part of #102234
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
displays integration activity information if the activity came from an
activity

<img width="505" height="75" alt="image"
src="https://github.com/user-attachments/assets/f3d65394-a831-455f-ae1d-c0e44690981b"
/>

part of #102234
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants