chore(preprod): Improve no results content on comparison page#102438
Merged
rbro112 merged 1 commit intoOct 30, 2025
Conversation
github-actions
Bot
added
the
Scope: Frontend
rbro112
changed the title
trevor-e
approved these changes
Oct 30, 2025
| <SimpleTable.Empty> | ||
| <Stack gap="lg" align="center" justify="center"> | ||
| <Text size="lg" variant="muted" bold> | ||
| {t('No results found')} |
Member
There was a problem hiding this comment.
nit: wdyt of "No results found matching your filters"
Member
Author
There was a problem hiding this comment.
Dan pushed for "No results found" (originally had No results found < 500B) since it was concise, so I'd say we just leave as-is
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102438 +/- ##
========================================
Coverage 80.90% 80.90%
========================================
Files 8825 8825
Lines 389987 389986 -1
Branches 24799 24799
========================================
Hits 315523 315523
+ Misses 74113 74112 -1
Partials 351 351 |
rbro112
force-pushed
the
ryan/improve_no_results_content_on_comparison_page
branch
from
9b010c9 to
7912d5e
Compare
rbro112
deleted the
ryan/improve_no_results_content_on_comparison_page
branch
isabellaenriquez
pushed a commit
that referenced
this pull request
Oct 31, 2025
Worked with Dan on the copy here: - Updates filter to be more concise - Adds richer empty state with button to turn off the hide small changes filter - Lock the Items changed: X value to be the original items, indicating that things did change in all cases Resolves EME-485 Before <img width="1500" height="470" alt="Screenshot 2025-10-30 at 1 56 55 PM" src="https://github.com/user-attachments/assets/7dc8b731-0383-436f-97c6-d4a35a960d58" /> After: <img width="1486" height="433" alt="Screenshot 2025-10-30 at 2 00 58 PM" src="https://github.com/user-attachments/assets/c3a645ee-722a-43f0-b952-8645856340b3" />
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
Worked with Dan on the copy here: - Updates filter to be more concise - Adds richer empty state with button to turn off the hide small changes filter - Lock the Items changed: X value to be the original items, indicating that things did change in all cases Resolves EME-485 Before <img width="1500" height="470" alt="Screenshot 2025-10-30 at 1 56 55 PM" src="https://github.com/user-attachments/assets/7dc8b731-0383-436f-97c6-d4a35a960d58" /> After: <img width="1486" height="433" alt="Screenshot 2025-10-30 at 2 00 58 PM" src="https://github.com/user-attachments/assets/c3a645ee-722a-43f0-b952-8645856340b3" />
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Worked with Dan on the copy here: - Updates filter to be more concise - Adds richer empty state with button to turn off the hide small changes filter - Lock the Items changed: X value to be the original items, indicating that things did change in all cases Resolves EME-485 Before <img width="1500" height="470" alt="Screenshot 2025-10-30 at 1 56 55 PM" src="https://github.com/user-attachments/assets/7dc8b731-0383-436f-97c6-d4a35a960d58" /> After: <img width="1486" height="433" alt="Screenshot 2025-10-30 at 2 00 58 PM" src="https://github.com/user-attachments/assets/c3a645ee-722a-43f0-b952-8645856340b3" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Worked with Dan on the copy here:
Resolves EME-485
Before
After:
