fix(sub v3): Show limited subscription details to non-billing users #102492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102492 +/- ##
========================================
Coverage 80.89% 80.89%
========================================
Files 8847 8847
Lines 390072 390072
Branches 24812 24812
========================================
Hits 315559 315559
Misses 74148 74148
Partials 365 365 |
Member
Author
There was a problem hiding this comment.
the hasPaymentSource logic is done in the parent so it doesn't make sense to test it here
brendanhsentry
approved these changes
Oct 31, 2025
jjbayer
pushed a commit
that referenced
this pull request
Nov 3, 2025
…102492) <img width="2293" height="1045" alt="Screenshot 2025-10-31 at 1 21 50 PM" src="https://github.com/user-attachments/assets/b5a2fa11-393f-4691-990a-40ad6f7e31af" /> - Any user on self-serve org can see reserved spend and PAYG spend columns - Any user on self-serve org can see a read-only version of the PAYG card - Adds back payment source check for PAYG edit
shashjar
pushed a commit
that referenced
this pull request
Nov 4, 2025
…102492) <img width="2293" height="1045" alt="Screenshot 2025-10-31 at 1 21 50 PM" src="https://github.com/user-attachments/assets/b5a2fa11-393f-4691-990a-40ad6f7e31af" /> - Any user on self-serve org can see reserved spend and PAYG spend columns - Any user on self-serve org can see a read-only version of the PAYG card - Adds back payment source check for PAYG edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.