Skip to content

fix(replay): Fix overflow on replay snippets inside issues views #102542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

fix(replay): Fix overflow on replay snippets inside issues views #102542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions static/app/components/events/eventReplay/replayClipPreviewPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ const PlayerContainer = styled(FluidHeight)`
@media (min-width: ${p => p.theme.breakpoints.sm}) {
min-height: ${REPLAY_LOADING_HEIGHT + 16}px;
}
overflow: unset;
`;

const StyledNegativeSpaceContainer = styled(NegativeSpaceContainer)`
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/events/eventReplay/replayPreviewPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ const PlayerPanel = styled('div')`
gap: ${space(1)};
flex-direction: column;
flex-grow: 1;
overflow: hidden;
height: 100%;
Comment on lines 197 to 199
Copy link

@sentry sentry bot Nov 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing overflow: hidden; from PlayerPanel may cause unintended content overflow. PlayerPanel is a flex container with flex-direction: column and flex-grow: 1, and removing the overflow constraint could lead to child elements extending beyond the intended boundaries. Please verify that all child components (particularly ReplayPlayer inside StaticPanel and TimeAndScrubberGrid) properly manage their sizing and don't cause layout shifts or visual issues when overflow is allowed.
Severity: MEDIUM

🤖 Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/components/events/eventReplay/replayPreviewPlayer.tsx#L197-L199

Potential issue: Removing `overflow: hidden;` from `PlayerPanel` may cause unintended
content overflow. `PlayerPanel` is a flex container with `flex-direction: column` and
`flex-grow: 1`, and removing the overflow constraint could lead to child elements
extending beyond the intended boundaries. Please verify that all child components
(particularly `ReplayPlayer` inside `StaticPanel` and `TimeAndScrubberGrid`) properly
manage their sizing and don't cause layout shifts or visual issues when overflow is
allowed.

Did we get this right? 👍 / 👎 to inform future reviews.

`;

Expand All @@ -208,6 +207,7 @@ const PreviewPlayerContainer = styled(FluidHeight)<{isSidebarOpen: boolean}>`
gap: ${space(2)};
background: ${p => p.theme.background};
height: unset;
overflow: unset;

:fullscreen {
padding: ${space(1)};
Expand Down
1 change: 1 addition & 0 deletions static/app/views/issueDetails/groupReplays/groupReplaysPlayer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ const PlayerContainer = styled(FluidHeight)`
@media (min-width: ${p => p.theme.breakpoints.sm}) {
min-height: ${REPLAY_LOADING_HEIGHT_LARGE}px;
}
overflow: unset;
`;

const StyledNegativeSpaceContainer = styled(NegativeSpaceContainer)`
Expand Down
Loading