-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix(replay): Fix overflow on replay snippets inside issues views #102542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ryan953
commented
Nov 3, 2025
| Issue Details | |
|---|---|
| Before | ![]() |
| After | ![]() |
| Issues > Replays | |
|---|---|
| Before | ![]() |
| After | ![]() |
|
All the files changed here are directly related to these two spots in the app, nothing else seems to use them. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #102542 +/- ##
===========================================
- Coverage 80.99% 80.88% -0.12%
===========================================
Files 8865 8860 -5
Lines 392651 390438 -2213
Branches 24834 24834
===========================================
- Hits 318015 315789 -2226
- Misses 74271 74284 +13
Partials 365 365 |
|
@sentry review |
| flex-direction: column; | ||
| flex-grow: 1; | ||
| overflow: hidden; | ||
| height: 100%; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing overflow: hidden; from PlayerPanel may cause unintended content overflow. PlayerPanel is a flex container with flex-direction: column and flex-grow: 1, and removing the overflow constraint could lead to child elements extending beyond the intended boundaries. Please verify that all child components (particularly ReplayPlayer inside StaticPanel and TimeAndScrubberGrid) properly manage their sizing and don't cause layout shifts or visual issues when overflow is allowed.
Severity: MEDIUM
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/components/events/eventReplay/replayPreviewPlayer.tsx#L197-L199
Potential issue: Removing `overflow: hidden;` from `PlayerPanel` may cause unintended
content overflow. `PlayerPanel` is a flex container with `flex-direction: column` and
`flex-grow: 1`, and removing the overflow constraint could lead to child elements
extending beyond the intended boundaries. Please verify that all child components
(particularly `ReplayPlayer` inside `StaticPanel` and `TimeAndScrubberGrid`) properly
manage their sizing and don't cause layout shifts or visual issues when overflow is
allowed.
Did we get this right? 👍 / 👎 to inform future reviews.
…2542) | | Issue Details | | --- | --- | | Before | <img width="676" height="124" alt="Screenshot 2025-11-03 at 10 59 15 AM" src="https://github.com/user-attachments/assets/7c7e8d82-9d82-48ef-826e-95230ef60341" /> | | After | <img width="713" height="124" alt="Screenshot 2025-11-03 at 10 59 07 AM" src="https://github.com/user-attachments/assets/ed8cf0a4-1349-40da-b094-8bbbe87dfb20" /> | | Issues > Replays | | --- | --- | | Before | <img width="661" height="107" alt="Screenshot 2025-11-03 at 10 58 35 AM" src="https://github.com/user-attachments/assets/0d2179ea-9295-4c9d-9131-e56e3effc423" /> | | After | <img width="661" height="107" alt="Screenshot 2025-11-03 at 10 58 47 AM" src="https://github.com/user-attachments/assets/3a70cb6b-00bf-4efb-ba23-a7fcb191e38f" /> |
…2542) | | Issue Details | | --- | --- | | Before | <img width="676" height="124" alt="Screenshot 2025-11-03 at 10 59 15 AM" src="https://github.com/user-attachments/assets/7c7e8d82-9d82-48ef-826e-95230ef60341" /> | | After | <img width="713" height="124" alt="Screenshot 2025-11-03 at 10 59 07 AM" src="https://github.com/user-attachments/assets/ed8cf0a4-1349-40da-b094-8bbbe87dfb20" /> | | Issues > Replays | | --- | --- | | Before | <img width="661" height="107" alt="Screenshot 2025-11-03 at 10 58 35 AM" src="https://github.com/user-attachments/assets/0d2179ea-9295-4c9d-9131-e56e3effc423" /> | | After | <img width="661" height="107" alt="Screenshot 2025-11-03 at 10 58 47 AM" src="https://github.com/user-attachments/assets/3a70cb6b-00bf-4efb-ba23-a7fcb191e38f" /> |
…2542) | | Issue Details | | --- | --- | | Before | <img width="676" height="124" alt="Screenshot 2025-11-03 at 10 59 15 AM" src="https://github.com/user-attachments/assets/7c7e8d82-9d82-48ef-826e-95230ef60341" /> | | After | <img width="713" height="124" alt="Screenshot 2025-11-03 at 10 59 07 AM" src="https://github.com/user-attachments/assets/ed8cf0a4-1349-40da-b094-8bbbe87dfb20" /> | | Issues > Replays | | --- | --- | | Before | <img width="661" height="107" alt="Screenshot 2025-11-03 at 10 58 35 AM" src="https://github.com/user-attachments/assets/0d2179ea-9295-4c9d-9131-e56e3effc423" /> | | After | <img width="661" height="107" alt="Screenshot 2025-11-03 at 10 58 47 AM" src="https://github.com/user-attachments/assets/3a70cb6b-00bf-4efb-ba23-a7fcb191e38f" /> |



