fix(deletions): Delete seer matched group hash metadata first #102612
+16
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #102612 +/- ##
========================================
Coverage 80.93% 80.93%
========================================
Files 8930 8930
Lines 391174 391191 +17
Branches 24858 24858
========================================
+ Hits 316579 316629 +50
+ Misses 74227 74194 -33
Partials 368 368 |
armenzg
force-pushed
the
0/fix/group_hash_metadata/cleanup/armenzg
branch
2 times, most recently
from
9fbee5c to
a3951b3
Compare
|
bugbot run |
armenzg
changed the title
armenzg
commented
Nov 3, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
armenzg
force-pushed
the
0/fix/group_hash_metadata/cleanup/armenzg
branch
from
a3951b3 to
8c99fc1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
bugbot run |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
armenzg
commented
Nov 4, 2025
| # If we update the columns first, the deletion of the grouphash metadata rows will have less work to do, | ||
| # thus, improving the performance of the deletion. | ||
| if options.get("deletions.group-hashes-metadata.update-seer-matched-grouphash-ids"): | ||
| GroupHashMetadata.objects.filter(seer_matched_grouphash_id__in=hash_ids).update( |
There was a problem hiding this comment.
This is what we should have done from the beginning (#101720).
cvxluo
approved these changes
Nov 4, 2025
armenzg
added a commit
that referenced
this pull request
Nov 5, 2025
This will ensure we iteratively delete chunks of Activity rather than failing during Group instance delete. This error will show en masse once the cleanup script runs again. This will start happening since we enabled #102612 today. Fixes [SENTRY-5BYJ](https://sentry.sentry.io/issues/6997944963/).
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: |
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
When deleting a GroupHash row, all GroupHashMetadata rows pointing to it via `seer_matched_grouphash` need updating (see code): https://github.com/getsentry/sentry/blob/698262018e6009759d8562e2da63be749df7c32d/src/sentry/models/grouphashmetadata.py#L115-L118 Before #101720, we would only delete GroupHash rows and that would time out because we would stomp queries longer than 30 seconds. In #101720 we added the deletion of the GroupHashMetadata rows but we should have also added the updating. The new code will have these three stages: ``` GroupHashMetadata.objects.filter(seer_matched_grouphash_id__in=hash_ids).update(seer_matched_grouphash=None) GroupHashMetadata.objects.filter(grouphash_id__in=hash_ids).delete() GroupHash.objects.filter(id__in=hash_ids).delete() ``` Fixes [SENTRY-5ABJ](https://sentry.sentry.io/issues/6930113529/). For posterity, this is the top of the stack trace: ``` OperationalError canceling statement due to user request SQL: UPDATE "sentry_grouphashmetadata" SET "seer_matched_grouphash_id" = NULL WHERE "sentry_grouphashmetadata"."seer_matched_grouphash_id" IN (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s) ```
armenzg
added a commit
that referenced
this pull request
Nov 6, 2025
This will ensure we iteratively delete chunks of Activity rather than failing during Group instance delete. This error will show en masse once the cleanup script runs again. This will start happening since we enabled #102612 today. Fixes [SENTRY-5BYJ](https://sentry.sentry.io/issues/6997944963/).
armenzg
added a commit
that referenced
this pull request
Nov 6, 2025
This is a follow-up to #102612. Fixes [SENTRY-5C13](https://sentry.sentry.io/issues/7001709353/).
armenzg
added a commit
that referenced
this pull request
Nov 6, 2025
This is a follow-up to #102612. Fixes [SENTRY-5C13](https://sentry.sentry.io/issues/7001709353/). For posterity ``` OperationalError canceling statement due to user request SQL: UPDATE "sentry_grouphashmetadata" SET "seer_matched_grouphash_id" = NULL WHERE "sentry_grouphashmetadata"."seer_matched_grouphash_id" IN (%s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s, %s) ``` [Link](https://github.com/getsentry/sentry/blob/cdfbaa2cebe0f119104586cbe11da667072d5637/src/sentry/deletions/defaults/group.py#L267-L272) to code: ```python if options.get("deletions.group-hashes-metadata.update-seer-matched-grouphash-ids"): # This is the line where the error comes from GroupHashMetadata.objects.filter( seer_matched_grouphash_id__in=hash_ids ).update(seer_matched_grouphash=None) GroupHashMetadata.objects.filter(grouphash_id__in=hash_ids).delete() GroupHash.objects.filter(id__in=hash_ids).delete() ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a GroupHash row, all GroupHashMetadata rows pointing to it via
seer_matched_grouphashneed updating (see code):sentry/src/sentry/models/grouphashmetadata.py
Lines 115 to 118 in 6982620
Before #101720, we would only delete GroupHash rows and that would time out because we would stomp queries longer than 30 seconds. In #101720 we added the deletion of the GroupHashMetadata rows but we should have also added the updating.
The new code will have these three stages:
Fixes SENTRY-5ABJ.
For posterity, this is the top of the stack trace: