fix(typing): Type src/sentry/integrations/source_code_management#102704
Merged
Conversation
Pretty simple addition of types. `get_repository_choices` has a weird command flow that requires an assert for mypy to recognize that a path is unreachable, but I feel confident in the correctness there.
github-actions
Bot
added
the
Scope: Backend
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #102704 +/- ##
===========================================
+ Coverage 80.91% 80.93% +0.02%
===========================================
Files 8929 8929
Lines 391242 391284 +42
Branches 24866 24866
===========================================
+ Hits 316574 316688 +114
+ Misses 74300 74228 -72
Partials 368 368 |
wedamija
approved these changes
Nov 5, 2025
priscilawebdev
pushed a commit
that referenced
this pull request
Nov 6, 2025
…2704) Pretty simple addition of types. `get_repository_choices` has a weird command flow that requires an assert for mypy to recognize that a path is unreachable, but I feel confident in the correctness there.
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
…2704) Pretty simple addition of types. `get_repository_choices` has a weird command flow that requires an assert for mypy to recognize that a path is unreachable, but I feel confident in the correctness there.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
…2704) Pretty simple addition of types. `get_repository_choices` has a weird command flow that requires an assert for mypy to recognize that a path is unreachable, but I feel confident in the correctness there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretty simple addition of types.
get_repository_choiceshas a weird command flow that requires an assert for mypy to recognize that a path is unreachable, but I feel confident in the correctness there.