Skip to content

chore(metrics): Remove legacy post process metrics #102780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

chore(metrics): Remove legacy post process metrics #102780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4170a9
rm post process metrics
roggenkemper Nov 5, 2025
3921967
rm test
roggenkemper Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/sentry/tasks/post_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,32 +659,6 @@ def get_event_raise_exception() -> Event:
tags=metric_tags,
)

if not is_reprocessed:
received_at = event.data.get("received")
saved_at = event.data.get("nodestore_insert")
post_processed_at = time()

if saved_at:
metrics.timing(
"events.saved_to_post_processed",
post_processed_at - saved_at,
instance=event.data["platform"],
tags=metric_tags,
)
else:
metrics.incr("events.missing_nodestore_insert", tags=metric_tags)

if received_at:
metrics.timing(
"events.time-to-post-process",
post_processed_at - received_at,
instance=event.data["platform"],
tags=metric_tags,
)

else:
metrics.incr("events.missing_received", tags=metric_tags)


def run_post_process_job(job: PostProcessJob) -> None:
group_event = job["event"]
Expand Down
1 change: 1 addition & 0 deletions src/sentry/utils/event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ def track_event_since_received(

received_at = event_data.get("received")
if not received_at:
metrics.incr("events.missing_received", tags=tags)
return

platform = event_data.get("platform")
Expand Down
22 changes: 0 additions & 22 deletions tests/sentry/tasks/test_post_process.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,28 +191,6 @@ def test_processing_cache_cleared_with_commits(self) -> None:
)
assert event_processing_store.get(cache_key) is None

@patch("sentry.utils.metrics.timing")
@patch("sentry.tasks.post_process.logger")
def test_time_to_process_metric(
self, logger_mock: MagicMock, metric_timing_mock: MagicMock
) -> None:
event = self.create_event(data={}, project_id=self.project.id)
self.call_post_process_group(
is_new=True,
is_regression=False,
is_new_group_environment=True,
event=event,
)
metric_timing_mock.assert_any_call(
"events.time-to-post-process",
mock.ANY,
instance=mock.ANY,
tags={"occurrence_type": mock.ANY},
)
assert "tasks.post_process.old_time_to_post_process" not in [
args[0] for args in logger_mock.warning.call_args_list
]


class DeriveCodeMappingsProcessGroupTestMixin(BasePostProgressGroupMixin):
def _create_event(
Expand Down
Loading