fix(replay) - useReplayTableSort now properly uses DEFAULT_SORT #102882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ryan953
approved these changes
Nov 7, 2025
Member
ryan953
left a comment
ryan953
left a comment
There was a problem hiding this comment.
the useRef probably isn't doing anything useful actually in this hook. It's applied to the sortType outside of useCallback, so values returned from the hook will be 'new' each time because the value inside .current is new each time.
Looks good for better sort defaults.
Before we had -started_at and asc which are not the same sort direction. Now we have -started_at and desc which are the same!
Member
Author
|
@ryan953 I removed the useRef and tested. Let me know your thoughts! |
billyvg
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useReplayTableSort isn't using the
DEFAULT_SORTtable as it should be.