Skip to content

fix(replay) - useReplayTableSort now properly uses DEFAULT_SORT #102882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 7, 2025
Merged

fix(replay) - useReplayTableSort now properly uses DEFAULT_SORT #102882

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b91197
fix(replay) - useReplayTableSort now properly uses DEFAULT_SORT
jerryzhou196 Nov 6, 2025
a09191c
fix(replay): address cursor comment
jerryzhou196 Nov 6, 2025
cc417da
Merge branch 'master' into fix-use-table-sort
jerryzhou196 Nov 6, 2025
6aa8548
fix(replay): simplify default sort handling in useReplayTableSort
jerryzhou196 Nov 7, 2025
bc08f54
Merge branch 'master' into fix-use-table-sort
jerryzhou196 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions static/app/components/replays/table/useReplayTableSort.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {useCallback, useRef} from 'react';
import {useCallback} from 'react';

import {trackAnalytics} from 'sentry/utils/analytics';
import {encodeSort} from 'sentry/utils/discover/eventView';
Expand All @@ -12,18 +12,17 @@ interface Props {
queryParamKey?: string;
}

const DEFAULT_SORT = {field: 'started_at', kind: 'asc'} as const;
const DEFAULT_SORT = {field: 'started_at', kind: 'desc'} as const;

export default function useReplayTableSort({
defaultSort = DEFAULT_SORT,
queryParamKey = 'sort',
}: Props = {}) {
const defaultSortRef = useRef(defaultSort);
const organization = useOrganization();

const {getParamValue, setParamValue} = useUrlParams(queryParamKey, '-started_at');
const {getParamValue, setParamValue} = useUrlParams(queryParamKey, '');
const sortQuery = getParamValue();
const sortType = decodeSorts(sortQuery).at(0) ?? defaultSortRef.current;
const sortType = decodeSorts(sortQuery).at(0) ?? defaultSort;

const handleSortClick = useCallback(
(key: string) => {
Expand Down
Loading