Skip to content

fix(aci): fix error state for nonexistent monitor details #102929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
Merged

fix(aci): fix error state for nonexistent monitor details #102929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion static/app/views/automations/detail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,6 +175,7 @@ function AutomationDetailLoadingStates({automationId}: {automationId: string}) {
data: automation,
isPending,
isError,
error,
refetch,
} = useAutomationQuery(automationId);

Expand All @@ -183,7 +184,12 @@ function AutomationDetailLoadingStates({automationId}: {automationId: string}) {
}

if (isError) {
return <LoadingError onRetry={refetch} />;
return (
<LoadingError
message={error.status === 404 ? t('The alert could not be found.') : undefined}
onRetry={refetch}
/>
);
}

return <AutomationDetailContent automation={automation} />;
Expand Down
10 changes: 8 additions & 2 deletions static/app/views/detectors/detail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,10 @@ import {useDetectorQuery} from 'sentry/views/detectors/hooks';
function DetectorDetailsLoadingStates({
detectorId,
project,
isFetchingProjects,
}: {
detectorId: string;
isFetchingProjects: boolean;
project: Project | undefined;
}) {
const {
Expand All @@ -26,7 +28,7 @@ function DetectorDetailsLoadingStates({
refetch,
} = useDetectorQuery(detectorId);

if (isPending || !project) {
if (isPending || isFetchingProjects) {
return <LoadingIndicator />;
}

Expand Down Expand Up @@ -67,7 +69,11 @@ export default function DetectorDetails() {
id="DetectorDetails-Body"
isLoading={isLoading}
>
<DetectorDetailsLoadingStates detectorId={params.detectorId} project={project} />
<DetectorDetailsLoadingStates
detectorId={params.detectorId}
project={project}
isFetchingProjects={isFetchingProjects}
/>
</VisuallyCompleteWithData>
);
}
Loading