-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(onboarding): Remove unused node utils #102939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(onboarding): Remove unused node utils #102939
Conversation
| import {getUploadSourceMapsStep} from 'sentry/components/onboarding/gettingStartedDoc/utils'; | ||
| import {AwsLambdaArn} from 'sentry/gettingStartedDocs/node/awslambda/awslambdaArnSelector'; | ||
| import {InstallationMethod} from 'sentry/gettingStartedDocs/node/awslambda/utils'; | ||
| import {getInstallCodeBlock} from 'sentry/gettingStartedDocs/node/node/utils'; | ||
| import {t, tct} from 'sentry/locale'; | ||
| import {getInstallCodeBlock} from 'sentry/utils/gettingStartedDocs/node'; | ||
|
|
||
| import type {Params, PlatformOptions} from './utils'; | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Multiple files import from a deleted module sentry/utils/gettingStartedDocs/node, causing module resolution errors.
Severity: CRITICAL | Confidence: 1.00
🔍 Detailed Analysis
The file static/app/utils/gettingStartedDocs/node.tsx was removed, and its functions were moved to static/app/gettingStartedDocs/node/node/utils.tsx. However, several files, including static/app/gettingStartedDocs/node/awslambda/profiling.tsx, static/app/gettingStartedDocs/bun/bun/index.tsx, and multiple javascript framework files, still import from the old, non-existent path 'sentry/utils/gettingStartedDocs/node'. This will lead to module resolution failures and "Module not found" errors when these documentation pages attempt to load.
💡 Suggested Fix
Update all remaining import statements that reference 'sentry/utils/gettingStartedDocs/node' to the new path 'sentry/gettingStartedDocs/node/node/utils' in affected files.
🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/gettingStartedDocs/node/awslambda/onboarding.tsx#L4-L11
Potential issue: The file `static/app/utils/gettingStartedDocs/node.tsx` was removed,
and its functions were moved to `static/app/gettingStartedDocs/node/node/utils.tsx`.
However, several files, including
`static/app/gettingStartedDocs/node/awslambda/profiling.tsx`,
`static/app/gettingStartedDocs/bun/bun/index.tsx`, and multiple `javascript` framework
files, still import from the old, non-existent path
`'sentry/utils/gettingStartedDocs/node'`. This will lead to module resolution failures
and "Module not found" errors when these documentation pages attempt to load.
Did we get this right? 👍 / 👎 to inform future reviews.
ArthurKnaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
andreiborza
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.