Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/gettingStartedDocs/bun/bun/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import {
feedbackOnboardingJsLoader,
replayOnboardingJsLoader,
} from 'sentry/gettingStartedDocs/javascript/jsLoader/jsLoader';
import {getNodeLogsOnboarding} from 'sentry/utils/gettingStartedDocs/node';
import {getNodeLogsOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';

import {crashReport} from './crashReport';
import {onboarding} from './onboarding';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {getNodeAgentMonitoringOnboarding} from 'sentry/utils/gettingStartedDocs/node';
import {getNodeAgentMonitoringOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';

export const agentMonitoring = getNodeAgentMonitoringOnboarding({
packageName: '@sentry/astro',
Expand Down
2 changes: 1 addition & 1 deletion static/app/gettingStartedDocs/javascript/nextjs.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ import {
getReplayVerifyStep,
} from 'sentry/components/onboarding/gettingStartedDoc/utils/replayOnboarding';
import {featureFlag} from 'sentry/gettingStartedDocs/javascript/javascript/featureFlag';
import {getNodeAgentMonitoringOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';
import {t, tct} from 'sentry/locale';
import {
getJavascriptFullStackOnboarding,
getJavascriptLogsFullStackOnboarding,
} from 'sentry/utils/gettingStartedDocs/javascript';
import {getNodeAgentMonitoringOnboarding} from 'sentry/utils/gettingStartedDocs/node';

type Params = DocsParams;

Expand Down
2 changes: 1 addition & 1 deletion static/app/gettingStartedDocs/javascript/nuxt.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ import {
getReplayVerifyStep,
} from 'sentry/components/onboarding/gettingStartedDoc/utils/replayOnboarding';
import {featureFlag} from 'sentry/gettingStartedDocs/javascript/javascript/featureFlag';
import {getNodeAgentMonitoringOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';
import {t, tct, tctCode} from 'sentry/locale';
import {
getJavascriptLogsFullStackOnboarding,
getJavascriptProfilingOnboarding,
} from 'sentry/utils/gettingStartedDocs/javascript';
import {getNodeAgentMonitoringOnboarding} from 'sentry/utils/gettingStartedDocs/node';

type Params = DocsParams;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {getNodeAgentMonitoringOnboarding} from 'sentry/utils/gettingStartedDocs/node';
import {getNodeAgentMonitoringOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';

export const agentMonitoring = getNodeAgentMonitoringOnboarding({
packageName: '@sentry/react-router',
Expand Down
2 changes: 1 addition & 1 deletion static/app/gettingStartedDocs/javascript/remix.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ import {
getReplayVerifyStep,
} from 'sentry/components/onboarding/gettingStartedDoc/utils/replayOnboarding';
import {featureFlag} from 'sentry/gettingStartedDocs/javascript/javascript/featureFlag';
import {getNodeAgentMonitoringOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';
import {t, tct} from 'sentry/locale';
import {
getJavascriptFullStackOnboarding,
getJavascriptLogsFullStackOnboarding,
} from 'sentry/utils/gettingStartedDocs/javascript';
import {getNodeAgentMonitoringOnboarding} from 'sentry/utils/gettingStartedDocs/node';

type Params = DocsParams;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {getNodeAgentMonitoringOnboarding} from 'sentry/utils/gettingStartedDocs/node';
import {getNodeAgentMonitoringOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';

export const agentMonitoring = getNodeAgentMonitoringOnboarding({
packageName: '@sentry/solidstart',
Expand Down
2 changes: 1 addition & 1 deletion static/app/gettingStartedDocs/javascript/sveltekit.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,12 @@ import {
getReplayVerifyStep,
} from 'sentry/components/onboarding/gettingStartedDoc/utils/replayOnboarding';
import {featureFlag} from 'sentry/gettingStartedDocs/javascript/javascript/featureFlag';
import {getNodeAgentMonitoringOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';
import {t, tct} from 'sentry/locale';
import {
getJavascriptFullStackOnboarding,
getJavascriptLogsFullStackOnboarding,
} from 'sentry/utils/gettingStartedDocs/javascript';
import {getNodeAgentMonitoringOnboarding} from 'sentry/utils/gettingStartedDocs/node';

type Params = DocsParams;

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {getNodeAgentMonitoringOnboarding} from 'sentry/utils/gettingStartedDocs/node';
import {getNodeAgentMonitoringOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';

export const agentMonitoring = getNodeAgentMonitoringOnboarding({
packageName: '@sentry/tanstackstart-react',
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {getNodeAgentMonitoringOnboarding} from 'sentry/utils/gettingStartedDocs/node';
import {getNodeAgentMonitoringOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';

export const agentMonitoring = getNodeAgentMonitoringOnboarding({
packageName: '@sentry/aws-serverless',
Expand Down
2 changes: 1 addition & 1 deletion static/app/gettingStartedDocs/node/awslambda/logs.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {getNodeLogsOnboarding} from 'sentry/utils/gettingStartedDocs/node';
import {getNodeLogsOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';

export const logs = getNodeLogsOnboarding({
docsPlatform: 'aws-lambda',
Expand Down
2 changes: 1 addition & 1 deletion static/app/gettingStartedDocs/node/awslambda/mcp.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {getNodeMcpOnboarding} from 'sentry/utils/gettingStartedDocs/node';
import {getNodeMcpOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';

export const mcp = getNodeMcpOnboarding({
packageName: '@sentry/aws-serverless',
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import type {OnboardingConfig} from 'sentry/components/onboarding/gettingStarted
import {getUploadSourceMapsStep} from 'sentry/components/onboarding/gettingStartedDoc/utils';
import {AwsLambdaArn} from 'sentry/gettingStartedDocs/node/awslambda/awslambdaArnSelector';
import {InstallationMethod} from 'sentry/gettingStartedDocs/node/awslambda/utils';
import {getInstallCodeBlock} from 'sentry/gettingStartedDocs/node/node/utils';
import {t, tct} from 'sentry/locale';
import {getInstallCodeBlock} from 'sentry/utils/gettingStartedDocs/node';

import type {Params, PlatformOptions} from './utils';

Comment on lines 4 to 11
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Multiple files import from a deleted module sentry/utils/gettingStartedDocs/node, causing module resolution errors.
Severity: CRITICAL | Confidence: 1.00

🔍 Detailed Analysis

The file static/app/utils/gettingStartedDocs/node.tsx was removed, and its functions were moved to static/app/gettingStartedDocs/node/node/utils.tsx. However, several files, including static/app/gettingStartedDocs/node/awslambda/profiling.tsx, static/app/gettingStartedDocs/bun/bun/index.tsx, and multiple javascript framework files, still import from the old, non-existent path 'sentry/utils/gettingStartedDocs/node'. This will lead to module resolution failures and "Module not found" errors when these documentation pages attempt to load.

💡 Suggested Fix

Update all remaining import statements that reference 'sentry/utils/gettingStartedDocs/node' to the new path 'sentry/gettingStartedDocs/node/node/utils' in affected files.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/gettingStartedDocs/node/awslambda/onboarding.tsx#L4-L11

Potential issue: The file `static/app/utils/gettingStartedDocs/node.tsx` was removed,
and its functions were moved to `static/app/gettingStartedDocs/node/node/utils.tsx`.
However, several files, including
`static/app/gettingStartedDocs/node/awslambda/profiling.tsx`,
`static/app/gettingStartedDocs/bun/bun/index.tsx`, and multiple `javascript` framework
files, still import from the old, non-existent path
`'sentry/utils/gettingStartedDocs/node'`. This will lead to module resolution failures
and "Module not found" errors when these documentation pages attempt to load.

Did we get this right? 👍 / 👎 to inform future reviews.

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import {getNodeProfilingOnboarding} from 'sentry/utils/gettingStartedDocs/node';
import {getNodeProfilingOnboarding} from 'sentry/gettingStartedDocs/node/node/utils';

export const profiling = getNodeProfilingOnboarding({
packageName: '@sentry/aws-serverless',
Expand Down
Loading
Loading