perf(widget-builder): Prevent unnecessary re-render of DashboardDetail when opening the Widget Builder
#102984
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why is it checking `router` if it passes `navigate` to the constructor?
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
gggritso
deleted the
georgegritsouk/dain-1069-prevent-re-render-of-widget-builder-caused-by-widget
branch
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
…il` when opening the Widget Builder (#102984) `DashboardDetail` is the whole dashboard, so it's expensive to re-render. Right now, when the Widget Builder opens it re-renders twice. One of them is legitimate, because the Widget Builder is now open. One of them is because `widgetBuilderSelectionState` was re-calculated, which is not needed. We only need to recalculate the selection state if the URL selection changed. If it did not, skip it, and skip the render. This saves like a 300ms render in some cases. **Before:** <img width="310" height="190" alt="Screenshot 2025-11-07 at 3 37 09 PM" src="https://github.com/user-attachments/assets/490819f5-21a5-4621-91c8-c349377486e1" /> **After:** <img width="313" height="218" alt="Screenshot 2025-11-07 at 3 39 51 PM" src="https://github.com/user-attachments/assets/2b6f455a-7586-494d-af76-20fee4b85170" />
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
…il` when opening the Widget Builder (#102984) `DashboardDetail` is the whole dashboard, so it's expensive to re-render. Right now, when the Widget Builder opens it re-renders twice. One of them is legitimate, because the Widget Builder is now open. One of them is because `widgetBuilderSelectionState` was re-calculated, which is not needed. We only need to recalculate the selection state if the URL selection changed. If it did not, skip it, and skip the render. This saves like a 300ms render in some cases. **Before:** <img width="310" height="190" alt="Screenshot 2025-11-07 at 3 37 09 PM" src="https://github.com/user-attachments/assets/490819f5-21a5-4621-91c8-c349377486e1" /> **After:** <img width="313" height="218" alt="Screenshot 2025-11-07 at 3 39 51 PM" src="https://github.com/user-attachments/assets/2b6f455a-7586-494d-af76-20fee4b85170" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DashboardDetailis the whole dashboard, so it's expensive to re-render. Right now, when the Widget Builder opens it re-renders twice. One of them is legitimate, because the Widget Builder is now open. One of them is becausewidgetBuilderSelectionStatewas re-calculated, which is not needed.We only need to recalculate the selection state if the URL selection changed. If it did not, skip it, and skip the render. This saves like a 300ms render in some cases.
Before:
After:
