Skip to content

perf(widget-builder): Prevent unnecessary re-render of DashboardDetail when opening the Widget Builder #102984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2025
Merged

perf(widget-builder): Prevent unnecessary re-render of DashboardDetail when opening the Widget Builder #102984

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de28f73
Fix incorrect condition
gggritso Nov 7, 2025
c5a328e
Narrow down the comparison
gggritso Nov 7, 2025
1656578
Add docs
gggritso Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions static/app/views/dashboards/detail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,13 @@ class DashboardDetail extends Component<Props, State> {

if (
prevProps.organization !== this.props.organization ||
prevProps.location !== this.props.location ||
prevProps.router !== this.props.router ||
// The only part of `location` used by `WidgetLegendSelectionState` is
// `unselectedSeries`. Don't bother comparing anything else. Once this
// component is a functional component, we'll move the selection state
// into a hook, and make sure it doesn't re-render too much.
prevProps.location.query.unselectedSeries !==
this.props.location.query.unselectedSeries ||
prevProps.navigate !== this.props.navigate ||
prevProps.dashboard !== this.props.dashboard
) {
this.setState({
Expand Down
Loading