Skip to content

ref(checkout v3): Clean up routing #103069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 13, 2025
Merged

ref(checkout v3): Clean up routing #103069

merged 6 commits into from
Nov 13, 2025

Conversation

@isabellaenriquez
Copy link
Member

@isabellaenriquez isabellaenriquez commented Nov 10, 2025

  • Replace /checkout-v3/ with /checkout/
  • Redirect any legacy URLs (/settings/billing/checkout/) to /checkout/
  • Update in-app references to checkout links
  • Add domain redirect route for /checkout/:orgId
  • Corrects normalized form and absolute form of checkout URL

Requires https://github.com/getsentry/getsentry/pull/18792

@isabellaenriquez isabellaenriquez requested review from a team as code owners November 10, 2025 16:38
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Nov 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

cursor[bot]
cursor bot reviewed Nov 10, 2025
View reviewed changes
vbro
vbro approved these changes Nov 10, 2025
View reviewed changes
Copy link
Contributor

@vbro vbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Please monitor, or ping on-call to monitor, when merging this PR.

cursor[bot]
cursor bot reviewed Nov 12, 2025
View reviewed changes
static/gsApp/components/upgradeOrTrialButton.tsx Outdated
? `/settings/${slug}/billing/checkout/`
: `/settings/${slug}/billing/overview/`;
? '/checkout/'
: `settings/${slug}/billing/overview/`;
Copy link
Contributor

@cursor cursor bot Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Invalid Relative URL Paths

Missing leading slash in fallback URL path. The baseUrl for non-self-serve subscriptions is now settings/${slug}/billing/overview/ instead of /settings/${slug}/billing/overview/, which will create an invalid relative URL path when combined with the referrer query parameter.

Fix in Cursor Fix in Web

@codecov
Copy link

codecov bot commented Nov 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #103069      +/-   ##
===========================================
- Coverage   80.69%    80.69%   -0.01%     
===========================================
  Files        9226      9195      -31     
  Lines      394098    393389     -709     
  Branches    25121     24968     -153     
===========================================
- Hits       318031    317434     -597     
+ Misses      75619     75538      -81     
+ Partials      448       417      -31

@isabellaenriquez isabellaenriquez merged commit 1596475 into master Nov 13, 2025
69 checks passed
@isabellaenriquez isabellaenriquez deleted the isabella/co-routes branch November 13, 2025 16:53
@isabellaenriquez isabellaenriquez added the Trigger: Revert Add to a merged PR to revert it (skips CI) label Nov 13, 2025
@getsentry-bot
Copy link
Contributor

getsentry-bot commented Nov 13, 2025

PR reverted: 69fb355

getsentry-bot added a commit that referenced this pull request Nov 13, 2025
@getsentry-bot @isabellaenriquez
Revert "ref(checkout v3): Clean up routing (#103069)"
69fb355 
This reverts commit 1596475.

Co-authored-by: isabellaenriquez <45607721+isabellaenriquez@users.noreply.github.com>
This was referenced Nov 19, 2025
Merged
Merged
isabellaenriquez added a commit that referenced this pull request Nov 19, 2025
@isabellaenriquez
chore(checkout): Add path pattern (#103668)
6cdd208 
Add path pattern for `/checkout/`

Redo pt 1 of #103069
isabellaenriquez added a commit that referenced this pull request Nov 20, 2025
@isabellaenriquez
ref(checkout): Update route (#103665)
12491cd 
Redo pt 2 of #103069

Depends on #103668

This PR:
- Changes the new checkout route from `/checkout-v3/` to `/checkout/`
- Fixes all normalization patterns
- Adds a `/:orgId/` variant (needed for acceptance testing)
- Removes unnecessary redirect logic now that new checkout is GA
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@dashed dashed dashed approved these changes

@vbro vbro vbro approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components Trigger: Revert Add to a merged PR to revert it (skips CI)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@isabellaenriquez @getsentry-bot @dashed @vbro