chore(checkout): Add path pattern #103668
Merged
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| re.compile(r"^\/?(?!settings)[^/]+\/([^/]+)\/getting-started\/(.*)"), | ||
| r"/getting-started/\1/\2", | ||
| ), | ||
| (re.compile(r"^\/?checkout\/[^/]+\/(.*)"), r"/checkout/\1"), |
Contributor
There was a problem hiding this comment.
Bug: Checkout pattern misses paths without trailing slash
The checkout regex pattern requires a slash after the organization slug, so /checkout/acme (without trailing slash) won't match and won't be transformed, while /checkout/acme/ will transform to /checkout/. This creates inconsistent behavior. The pattern should use \/? instead of \/ before the capture group to handle both cases, similar to how the join-request pattern handles optional trailing slashes.
Member
Author
There was a problem hiding this comment.
the slash is required, similar to onboarding
dashed
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add path pattern for
/checkout/Redo pt 1 of #103069