feat(tracemetrics): Parse metric from aggregations #103102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parses the metric from aggregations instead of relying on the top level metric name/type. The top level ones still take precendence for better compatibility. It has the limitation that it only allows a single metric across all the aggregations.
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| ) | ||
| selected_metrics.add(metric) | ||
|
|
||
| if not selected_metrics: |
Contributor
There was a problem hiding this comment.
Bug: Equations Ignore Metric Aggregations
The _extra_conditions_from_columns method accepts an equations parameter but never processes it. When metric aggregates like sum(value,foo,counter,-) are used inside equations, the metric information won't be extracted, causing the query to miss the required metric filter conditions. This breaks the feature's core functionality of parsing metrics from aggregations when they appear in equations.
❌ 6 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
wmak
reviewed
Nov 12, 2025
| equations: list[str] | None, | ||
| ) -> TraceItemFilter | None: | ||
| # use the metric from the config first if it exists | ||
| if extra_conditions := self._extra_conditions_from_metric(search_resolver): |
Member
There was a problem hiding this comment.
This config is populated from the extra request params right? Is the long term plan to eventually stop supporting it?
Member
Author
There was a problem hiding this comment.
Correct. Trace metrics uses it own TraceMetricsSearchResolverConfig that inherits from SearchResolverConfig. This currently has top level configs to specify 1 metric. Long term, we'll remove that and only rely on the metric specified in the aggregation.
Comment on lines
+77
to
+78
| if len(selected_metrics) > 1: | ||
| raise InvalidSearchQuery("Cannot aggregate multiple metrics in 1 query.") |
Member
There was a problem hiding this comment.
two questions
- if you can't select multiple metrics in one query why do we need it in the aggregates?
- shouldn't we dedupe the selected_metrics list if there's multiple aggregates on the same metric?
Member
Author
There was a problem hiding this comment.
- We cant select multiple metrics today because EAP does not have support to allow us to express it yet. See EAP-313
selected_metricsis a set of tuples so it already dedupes, meaning it lets you select multiple aggregates on the same metric
wmak
approved these changes
Nov 12, 2025
Issues attributed to commits in this pull requestThis pull request was merged and Sentry observed the following issues: |
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
This parses the metric from aggregations instead of relying on the top level metric name/type. The top level ones still take precedence for better compatibility. It has the limitation that it only allows a single metric across all the aggregations.
Zylphrex
added a commit
that referenced
this pull request
Nov 13, 2025
Same as #103102 but for formulas so per_second and per_minute will work as well.
Zylphrex
added a commit
that referenced
this pull request
Nov 13, 2025
Same as #103102 but for formulas so per_second and per_minute will work as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses the metric from aggregations instead of relying on the top level metric name/type. The top level ones still take precedence for better compatibility. It has the limitation that it only allows a single metric across all the aggregations.