Skip to content

feat(tracemetrics): Parse metric from formulas #103303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2025
Merged

feat(tracemetrics): Parse metric from formulas #103303

merged 3 commits into from
Nov 13, 2025

Conversation

@Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Nov 13, 2025

Same as #103102 but for formulas so per_second and per_minute will work as well.

@Zylphrex
feat(tracemetrics): Parse metric from formulas
6aee813 
Same as #103102 but for formulas so per_second and per_minute will work as well.
@Zylphrex Zylphrex requested a review from a team as a code owner November 13, 2025 16:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 13, 2025
@codecov
Copy link

codecov bot commented Nov 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.00000% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/search/eap/columns.py 89.18% 4 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           master   #103303   +/-   ##
========================================
  Coverage   80.69%    80.69%           
========================================
  Files        9226      9226           
  Lines      394098    394114   +16     
  Branches    25121     25121           
========================================
+ Hits       318031    318045   +14     
- Misses      75619     75621    +2     
  Partials      448       448

@Zylphrex Zylphrex merged commit a7ca146 into master Nov 13, 2025
66 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/parse-metric-from-formulas branch November 13, 2025 20:35
@sentry
Copy link

sentry bot commented Nov 13, 2025

Issues attributed to commits in this pull request

This pull request was merged and Sentry observed the following issues:

Zylphrex added a commit that referenced this pull request Nov 14, 2025
@Zylphrex
test(tracemetrics): Re-enable skipped trace metrics tests
c41bbd9 
These tests failed because #103303 and #103071 were merged without being rebased
on each other. #103071 has since been reverted.

Fixes #103382
Fixes #103384
@Zylphrex Zylphrex mentioned this pull request Nov 14, 2025
Merged
Zylphrex added a commit that referenced this pull request Nov 14, 2025
@Zylphrex
test(tracemetrics): Re-enable skipped trace metrics tests (#103396)
98e4dd5 
These tests failed because #103303 and #103071 were merged without being
rebased on each other. #103071 has since been reverted.

Fixes #103382
Fixes #103384
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmak wmak wmak approved these changes

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zylphrex @wmak