ref(uptime): Restrict detector mode changes to superusers only #103178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
wedamija
approved these changes
Nov 11, 2025
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
Also, when a user modifies a detector, it should automatically switch to manual mode, from what I remember
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103178 +/- ##
===========================================
- Coverage 80.67% 80.66% -0.01%
===========================================
Files 9241 9241
Lines 393627 393640 +13
Branches 25053 25053
===========================================
+ Hits 317542 317548 +6
- Misses 75623 75630 +7
Partials 462 462 |
Member
Author
Let me verify we have a test for this behavior |
Adds validation to prevent non-superusers from creating or modifying uptime detectors with restricted mode values (AUTO_DETECTED_*). Only superusers (internal systems) can now set modes other than MANUAL. The validation smartly only triggers when mode is being changed, allowing users to pass config with an unchanged mode value. Fixes [NEW-621: Ensure Uptime detector `mode` is not configurable via API endpoints](https://linear.app/getsentry/issue/NEW-621/ensure-uptime-detector-mode-is-not-configurable-via-api-endpoints)
evanpurkhiser
force-pushed
the
evanpurkhiser/ref-uptime-restrict-detector-mode-changes-to-superusers-only
branch
from
30eb4f9 to
fbd03bd
Compare
evanpurkhiser
deleted the
evanpurkhiser/ref-uptime-restrict-detector-mode-changes-to-superusers-only
branch
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
Adds validation to prevent non-superusers from creating or modifying uptime detectors with restricted mode values (AUTO_DETECTED_*). Only superusers (internal systems) can now set modes other than MANUAL. The validation smartly only triggers when mode is being changed, allowing users to pass config with an unchanged mode value. Fixes [NEW-621: Ensure Uptime detector `mode` is not configurable via API endpoints](https://linear.app/getsentry/issue/NEW-621/ensure-uptime-detector-mode-is-not-configurable-via-api-endpoints)
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Adds validation to prevent non-superusers from creating or modifying uptime detectors with restricted mode values (AUTO_DETECTED_*). Only superusers (internal systems) can now set modes other than MANUAL. The validation smartly only triggers when mode is being changed, allowing users to pass config with an unchanged mode value. Fixes [NEW-621: Ensure Uptime detector `mode` is not configurable via API endpoints](https://linear.app/getsentry/issue/NEW-621/ensure-uptime-detector-mode-is-not-configurable-via-api-endpoints)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds validation to prevent non-superusers from creating or modifying
uptime detectors with restricted mode values (AUTO_DETECTED_*). Only
superusers (internal systems) can now set modes other than MANUAL.
The validation smartly only triggers when mode is being changed, allowing
users to pass config with an unchanged mode value.
Fixes NEW-621: Ensure Uptime detector
modeis not configurable via API endpoints