-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(crons): Refresh detector when environment is muted/unmuted #103186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
evanpurkhiser
merged 1 commit into
master
from
evanpurkhiser/ref-crons-refresh-detector-when-environment-is-muted-unmuted
Nov 12, 2025
Merged
ref(crons): Refresh detector when environment is muted/unmuted #103186
evanpurkhiser
merged 1 commit into
master
from
evanpurkhiser/ref-crons-refresh-detector-when-environment-is-muted-unmuted
Nov 12, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scttcper
reviewed
Nov 11, 2025
scttcper
reviewed
Nov 11, 2025
static/app/views/detectors/components/details/cron/index.spec.tsx
Outdated
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103186 +/- ##
===========================================
- Coverage 80.67% 80.67% -0.01%
===========================================
Files 9241 9241
Lines 393630 393629 -1
Branches 25053 25053
===========================================
- Hits 317546 317545 -1
Misses 75622 75622
Partials 462 462 |
Fixed [NEW-592: Muting cron environment does not refresh detector](https://linear.app/getsentry/issue/NEW-592/muting-cron-environment-does-not-refresh-detector) When muting/unmuting or deleting a cron monitor environment from the detector details page, the parent detector state wasn't being refreshed, causing stale data to display. Added onEnvironmentUpdated callback to DetailsTimeline component that invalidates the detector query when environment status changes, ensuring the UI stays in sync with the backend state.
474193e to
dc133f6
Compare
scttcper
approved these changes
Nov 12, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
When muting/unmuting or deleting a cron monitor environment from the detector details page, the parent detector state wasn't being refreshed, causing stale data to display. Added onEnvironmentUpdated callback to DetailsTimeline component that invalidates the detector query when environment status changes, ensuring the UI stays in sync with the backend state. Fixes [NEW-592: Muting cron environment does not refresh detector](https://linear.app/getsentry/issue/NEW-592/muting-cron-environment-does-not-refresh-detector)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When muting/unmuting or deleting a cron monitor environment from the detector details page, the parent detector state wasn't being refreshed, causing stale data to display.
Added onEnvironmentUpdated callback to DetailsTimeline component that invalidates the detector query when environment status changes, ensuring the UI stays in sync with the backend state.
Fixes NEW-592: Muting cron environment does not refresh detector