Skip to content

fix(aci): Rename metric medium threshold field #103202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2025
+17 −7
Merged

fix(aci): Rename metric medium threshold field #103202

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 17 additions & 7 deletions static/app/views/detectors/components/forms/metric/metric.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,24 +228,34 @@ function PriorityRow({

const thresholdAriaLabel = isHigh ? t('High threshold') : t('Medium threshold');

const directionField = (
const directionField = isHigh ? (
<DirectionField
aria-label={t('Threshold direction')}
name={METRIC_DETECTOR_FORM_FIELDS.conditionType}
hideLabel
inline
flexibleControlStateSize
choices={conditionChoices}
required={isHigh}
disabled={!isHigh}
defaultValue={conditionType}
required
preserveOnUnmount
/>
) : (
<DirectionField
aria-label={t('Threshold direction')}
name="conditionTypeDisplay"
hideLabel
inline
flexibleControlStateSize
choices={conditionChoices}
value={conditionType}
defaultValue={conditionType}
disabled
/>
);

return (
<PriorityRowContainer>
<PriorityDot $priority={priority} />
<PriorityDot priority={priority} />
<PriorityLabel>
{isHigh ? t('High priority') : t('Medium priority')}
{isHigh && <RequiredAsterisk>*</RequiredAsterisk>}
Expand Down Expand Up @@ -677,11 +687,11 @@ const PriorityRowContainer = styled('div')`
gap: ${space(1)};
`;

const PriorityDot = styled('div')<{$priority: 'high' | 'medium'}>`
const PriorityDot = styled('div')<{priority: 'high' | 'medium'}>`
Copy link
Member Author

@scttcper scttcper Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was weirdly named too

width: 8px;
height: 8px;
border-radius: 50%;
background-color: ${p => (p.$priority === 'high' ? p.theme.red300 : p.theme.yellow400)};
background-color: ${p => (p.priority === 'high' ? p.theme.red300 : p.theme.yellow400)};
flex-shrink: 0;
`;

Expand Down
Loading