fix(aci): Rename metric medium threshold field #103202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having both medium and high thresholds on the same name was causing issues with listeners downstream. Fixes an issue where switching between threshold and percent changed would detach useMetricDetectorFormField listeners.
github-actions
bot
added
the
Scope: Frontend
scttcper
commented
Nov 12, 2025
| `; | ||
|
|
||
| const PriorityDot = styled('div')<{$priority: 'high' | 'medium'}>` | ||
| const PriorityDot = styled('div')<{priority: 'high' | 'medium'}>` |
Member
Author
There was a problem hiding this comment.
this was weirdly named too
malwilley
approved these changes
Nov 12, 2025
Jesse-Box
pushed a commit
that referenced
this pull request
Nov 12, 2025
Having both medium and high thresholds on the same name was causing issues with listeners downstream. Fixes an issue where switching between threshold and percent changed would detach useMetricDetectorFormField listeners.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
Having both medium and high thresholds on the same name was causing issues with listeners downstream. Fixes an issue where switching between threshold and percent changed would detach useMetricDetectorFormField listeners.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having both medium and high thresholds on the same name was causing issues with listeners downstream. Fixes an issue where switching between threshold and percent changed would detach useMetricDetectorFormField listeners.