-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
ref(replays): Rename and export default sort constant for replay list; update usages across components #103248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… list; update usages across components - Changed `DEFAULT_SORT` to `DEFAULT_REPLAY_LIST_SORT` for clarity and consistency. - Updated `useReplayTableSort` to use the new constant. - Removed unused `DEFAULT_SORT` from `fetchReplayList`. - Updated sorting logic in `useReplaysFromIssue` and `useReplaysFromTransaction` to utilize the new constant. - Marked `useReplayList` as deprecated in favor of `useApiQuery`.
billyvg
reviewed
Nov 12, 2025
… functionality - Changed default sort in `useReplayTableSort` to use a decoded format for consistency. - Updated `orderby` logic in `useReplaysFromIssue` and `useReplaysFromTransaction` to remove unnecessary encoding. - Enhanced deprecation notice in `useReplayList` to clarify its reliance on deprecated components.
billyvg
approved these changes
Nov 12, 2025
billyvg
reviewed
Nov 12, 2025
…on notice - Changed default sort in `useReplayTableSort` to use a structured format for clarity and consistency. - Updated the deprecation message in `useReplayList` to better reflect the challenges of using `EventView`.
andrewshie-sentry
pushed a commit
that referenced
this pull request
Nov 13, 2025
…; update usages across components (#103248) - Changed `DEFAULT_SORT` to `DEFAULT_REPLAY_LIST_SORT` for clarity and consistency. - Updated `useReplayTableSort` to use the new constant. - Removed unused `DEFAULT_SORT` from `fetchReplayList`. - Updated sorting logic in `useReplaysFromIssue` and `useReplaysFromTransaction` to utilize the new constant. - Marked `useReplayList` as deprecated in favor of `useApiQuery`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEFAULT_SORTtoDEFAULT_REPLAY_LIST_SORTfor clarity and consistency.useReplayTableSortto use the new constant.DEFAULT_SORTfromfetchReplayList.useReplaysFromIssueanduseReplaysFromTransactionto utilize the new constant.useReplayListas deprecated in favor ofuseApiQuery.