Skip to content

Conversation

@jerryzhou196
Copy link
Member

  • Changed DEFAULT_SORT to DEFAULT_REPLAY_LIST_SORT for clarity and consistency.
  • Updated useReplayTableSort to use the new constant.
  • Removed unused DEFAULT_SORT from fetchReplayList.
  • Updated sorting logic in useReplaysFromIssue and useReplaysFromTransaction to utilize the new constant.
  • Marked useReplayList as deprecated in favor of useApiQuery.

… list; update usages across components

- Changed `DEFAULT_SORT` to `DEFAULT_REPLAY_LIST_SORT` for clarity and consistency.
- Updated `useReplayTableSort` to use the new constant.
- Removed unused `DEFAULT_SORT` from `fetchReplayList`.
- Updated sorting logic in `useReplaysFromIssue` and `useReplaysFromTransaction` to utilize the new constant.
- Marked `useReplayList` as deprecated in favor of `useApiQuery`.
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 12, 2025
@jerryzhou196 jerryzhou196 marked this pull request as ready for review November 12, 2025 19:13
@jerryzhou196 jerryzhou196 requested review from a team as code owners November 12, 2025 19:13
… functionality

- Changed default sort in `useReplayTableSort` to use a decoded format for consistency.
- Updated `orderby` logic in `useReplaysFromIssue` and `useReplaysFromTransaction` to remove unnecessary encoding.
- Enhanced deprecation notice in `useReplayList` to clarify its reliance on deprecated components.
…on notice

- Changed default sort in `useReplayTableSort` to use a structured format for clarity and consistency.
- Updated the deprecation message in `useReplayList` to better reflect the challenges of using `EventView`.
@jerryzhou196 jerryzhou196 merged commit 32704d7 into master Nov 12, 2025
47 checks passed
@jerryzhou196 jerryzhou196 deleted the move-default-sort-to-common-utils branch November 12, 2025 20:41
andrewshie-sentry pushed a commit that referenced this pull request Nov 13, 2025
…; update usages across components (#103248)

- Changed `DEFAULT_SORT` to `DEFAULT_REPLAY_LIST_SORT` for clarity and
consistency.
- Updated `useReplayTableSort` to use the new constant.
- Removed unused `DEFAULT_SORT` from `fetchReplayList`.
- Updated sorting logic in `useReplaysFromIssue` and
`useReplaysFromTransaction` to utilize the new constant.
- Marked `useReplayList` as deprecated in favor of `useApiQuery`.
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants