Skip to content

ref(profiling): remove flamegraph chunked query strategy feature flag #103284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 17, 2025
Merged

ref(profiling): remove flamegraph chunked query strategy feature flag #103284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2357320
ref(profiling): remove flamegraph chunked query strategy feature flag
viglia Nov 13, 2025
c142ebd
fix
viglia Nov 13, 2025
dc51e94
fix test_queries_profile_candidates_from_profiles
viglia Nov 13, 2025
2d89abc
fix test_queries_profile_candidates_from_profiles_with_continuous_pro…
viglia Nov 13, 2025
d3eb46f
fix test test_queries_profile_candidates_from_transactions
viglia Nov 13, 2025
8a209cd
fix test test_queries_profile_candidates_from_transactions_with_data
viglia Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
200 changes: 1 addition & 199 deletions src/sentry/profiles/flamegraph.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
Storage,
)

from sentry import features, options
from sentry import options
from sentry.search.eap.types import EAPResponse, SearchResolverConfig
from sentry.search.events.builder.discover import DiscoverQueryBuilder
from sentry.search.events.builder.profile_functions import ProfileFunctionsQueryBuilder
Expand Down Expand Up @@ -102,18 +102,8 @@ def get_profile_candidates(self) -> ProfileCandidates:
if self.data_source == "functions":
return self.get_profile_candidates_from_functions()
elif self.data_source == "transactions":
if features.has(
"organizations:profiling-flamegraph-use-increased-chunks-query-strategy",
self.snuba_params.organization,
):
return self.get_profile_candidates_from_transactions_v2()
return self.get_profile_candidates_from_transactions()
elif self.data_source == "profiles":
if features.has(
"organizations:profiling-flamegraph-use-increased-chunks-query-strategy",
self.snuba_params.organization,
):
return self.get_profile_candidates_from_profiles_v2()
return self.get_profile_candidates_from_profiles()
elif self.data_source == "spans":
return self.get_profile_candidates_from_spans()
Expand Down Expand Up @@ -190,50 +180,6 @@ def get_profile_candidates_from_functions(self) -> ProfileCandidates:

def get_profile_candidates_from_transactions(self) -> ProfileCandidates:
max_profiles = options.get("profiling.flamegraph.profile-set.size")

builder = self.get_transactions_based_candidate_query(query=self.query, limit=max_profiles)

results = builder.run_query(
Referrer.API_PROFILING_PROFILE_FLAMEGRAPH_TRANSACTION_CANDIDATES.value,
)
results = builder.process_results(results)

transaction_profile_candidates: list[TransactionProfileCandidate] = [
{
"project_id": row["project.id"],
"profile_id": row["profile.id"],
}
for row in results["data"]
if row["profile.id"] is not None
]

max_continuous_profile_candidates = max(
max_profiles - len(transaction_profile_candidates), 0
)

continuous_profile_candidates, _ = self.get_chunks_for_profilers(
[
ProfilerMeta(
project_id=row["project.id"],
profiler_id=row["profiler.id"],
thread_id=row["thread.id"],
start=row["precise.start_ts"],
end=row["precise.finish_ts"],
transaction_id=row["id"],
)
for row in results["data"]
if row["profiler.id"] is not None and row["thread.id"]
],
max_continuous_profile_candidates,
)

return {
"transaction": transaction_profile_candidates,
"continuous": continuous_profile_candidates,
}

def get_profile_candidates_from_transactions_v2(self) -> ProfileCandidates:
max_profiles = options.get("profiling.flamegraph.profile-set.size")
initial_chunk_delta_hours = options.get(
"profiling.flamegraph.query.initial_chunk_delta.hours"
)
Expand Down Expand Up @@ -503,150 +449,6 @@ def get_profile_candidates_from_profiles(self) -> ProfileCandidates:
if self.snuba_params.organization is None:
raise ValueError("`organization` is required and cannot be `None`")

max_profiles = options.get("profiling.flamegraph.profile-set.size")

referrer = Referrer.API_PROFILING_PROFILE_FLAMEGRAPH_PROFILE_CANDIDATES.value

transaction_profiles_builder = self.get_transactions_based_candidate_query(
query=None, limit=max_profiles
)

conditions = []

conditions.append(Condition(Column("project_id"), Op.IN, self.snuba_params.project_ids))

conditions.append(
Condition(Column("start_timestamp"), Op.LT, resolve_datetime64(self.snuba_params.end))
)

conditions.append(
Condition(Column("end_timestamp"), Op.GTE, resolve_datetime64(self.snuba_params.start))
)

environments = self.snuba_params.environment_names
if environments:
conditions.append(Condition(Column("environment"), Op.IN, environments))

continuous_profiles_query = Query(
match=Storage(StorageKey.ProfileChunks.value),
select=[
Column("project_id"),
Column("profiler_id"),
Column("chunk_id"),
Column("start_timestamp"),
Column("end_timestamp"),
],
where=conditions,
orderby=[OrderBy(Column("start_timestamp"), Direction.DESC)],
limit=Limit(max_profiles),
)

all_results = bulk_snuba_queries(
[
transaction_profiles_builder.get_snql_query(),
Request(
dataset=Dataset.Profiles.value,
app_id="default",
query=continuous_profiles_query,
tenant_ids={
"referrer": referrer,
"organization_id": self.snuba_params.organization.id,
},
),
],
referrer,
)

transaction_profile_results = transaction_profiles_builder.process_results(all_results[0])
continuous_profile_results = all_results[1]

transaction_profile_candidates: list[TransactionProfileCandidate] = [
{
"project_id": row["project.id"],
"profile_id": row["profile.id"],
}
for row in transaction_profile_results["data"]
if row["profile.id"] is not None
]

max_continuous_profile_candidates = max(
max_profiles - len(transaction_profile_candidates), 0
)

profiler_metas = [
ProfilerMeta(
project_id=row["project.id"],
profiler_id=row["profiler.id"],
thread_id=row["thread.id"],
start=row["precise.start_ts"],
end=row["precise.finish_ts"],
transaction_id=row["id"],
)
for row in transaction_profile_results["data"]
if row["profiler.id"] is not None and row["thread.id"]
]

continuous_profile_candidates: list[ContinuousProfileCandidate] = []
continuous_duration = 0.0

# If there are continuous profiles attached to transactions, we prefer those as
# the active thread id gives us more user friendly flamegraphs than without.
if profiler_metas:
continuous_profile_candidates, continuous_duration = self.get_chunks_for_profilers(
profiler_metas, max_continuous_profile_candidates
)

seen_chunks = {
(candidate["profiler_id"], candidate["chunk_id"])
for candidate in continuous_profile_candidates
}

always_use_direct_chunks = features.has(
"organizations:profiling-flamegraph-always-use-direct-chunks",
self.snuba_params.organization,
actor=self.request.user,
)

# If we still don't have any continuous profile candidates, we'll fall back to
# directly using the continuous profiling data
if not continuous_profile_candidates or always_use_direct_chunks:
total_duration = continuous_duration if always_use_direct_chunks else 0.0
max_duration = options.get("profiling.continuous-profiling.flamegraph.max-seconds")

for row in continuous_profile_results["data"]:

# Make sure to dedupe profile chunks so we don't reuse chunks
if (row["profiler_id"], row["chunk_id"]) in seen_chunks:
continue

start = datetime.fromisoformat(row["start_timestamp"]).timestamp()
end = datetime.fromisoformat(row["end_timestamp"]).timestamp()

candidate: ContinuousProfileCandidate = {
"project_id": row["project_id"],
"profiler_id": row["profiler_id"],
"chunk_id": row["chunk_id"],
"start": str(int(start * 1e9)),
"end": str(int(end * 1e9)),
}

continuous_profile_candidates.append(candidate)

total_duration += end - start

# can set max duration to negative to skip this check
if max_duration >= 0 and total_duration >= max_duration:
break

return {
"transaction": transaction_profile_candidates,
"continuous": continuous_profile_candidates,
}

def get_profile_candidates_from_profiles_v2(self) -> ProfileCandidates:
if self.snuba_params.organization is None:
raise ValueError("`organization` is required and cannot be `None`")

max_profiles = options.get("profiling.flamegraph.profile-set.size")
initial_chunk_delta_hours = options.get(
"profiling.flamegraph.query.initial_chunk_delta.hours"
Expand Down
Loading
Loading