Skip to content

Conversation

@jjbayer
Copy link
Member

@jjbayer jjbayer commented Nov 14, 2025

For performance issue detection, we shim the timestamp field for spans, but the detector code also accesses span.data and span.description.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 14, 2025
@codecov
Copy link

codecov bot commented Nov 14, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...rc/sentry/spans/consumers/process_segments/shim.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #103353      +/-   ##
===========================================
+ Coverage   80.67%    80.70%   +0.02%     
===========================================
  Files        9236      9241       +5     
  Lines      394524    394801     +277     
  Branches    25148     25148              
===========================================
+ Hits       318286    318615     +329     
+ Misses      75791     75739      -52     
  Partials      447       447              

@jjbayer jjbayer marked this pull request as ready for review November 14, 2025 14:05
@jjbayer jjbayer requested review from a team as code owners November 14, 2025 14:05
@jjbayer jjbayer requested review from a team and removed request for a team November 14, 2025 14:06
@jjbayer jjbayer merged commit c1aeb5e into master Nov 17, 2025
66 checks passed
@jjbayer jjbayer deleted the fix/performance-issues-more-fields branch November 17, 2025 08:14
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants