fix(replay): Fix infinite re-render in breadcrumbs #103373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an infinite re-rener in replay breadcrumbs when an HTML snippet is displayed and we scroll around quickly. Due to virtualized rows, we need to tell the virtualizer to update the row dimensions when we show the HTML snippet. When we scroll away and back, it is possible to hit a race condition where we call updateDimensions infinitely. Fixes JAVASCRIPT-31G4
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if ( | ||
| isPending !== prevExtractState.current || | ||
| (showSnippet && prevShowSnippet.current !== showSnippet) | ||
| ) { |
Contributor
There was a problem hiding this comment.
Bug: Virtualizer dimensions: Incomplete update logic.
The condition (showSnippet && prevShowSnippet.current !== showSnippet) only calls updateDimensions() when showSnippet transitions to true, but not when it transitions to false. This means dimensions won't update when hiding the snippet, potentially leaving the virtualizer with stale dimension data. The condition should be prevShowSnippet.current !== showSnippet without the showSnippet && prefix to handle both transitions.
Member
Author
There was a problem hiding this comment.
Correct, you can't hide the snippet.
Member
Author
|
@sentry review |
ryan953
approved these changes
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an infinite re-render in replay breadcrumbs when an HTML snippet is displayed and we scroll around quickly.
Due to virtualized rows, we need to tell the virtualizer to update the row dimensions when we show the HTML snippet.
When we scroll away and back, it is possible to hit a race condition where we call updateDimensions infinitely.
Fixes JAVASCRIPT-31G4