Skip to content

test(tracemetrics): Re-enable skipped trace metrics tests #103396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2025
+0 −2
Merged

test(tracemetrics): Re-enable skipped trace metrics tests #103396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion tests/snuba/api/endpoints/test_organization_events_stats_trace_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,6 @@ def test_top_events(self) -> None:
assert response.data["value2"]["meta"]["dataset"] == "tracemetrics"
assert response.data["Other"]["meta"]["dataset"] == "tracemetrics"

@pytest.mark.skip(reason="flaky: #103382")
def test_meta_accuracy(self):
metric_values = [1, 2, 3, 4]
Comment on lines 179 to 180
Copy link

@sentry sentry bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Flaky tests test_meta_accuracy and test_per_minute_formula are re-enabled without verified root cause resolution.
Severity: HIGH | Confidence: 0.90

🔍 Detailed Analysis

The pull request re-enables test_meta_accuracy and test_per_minute_formula which were previously marked as flaky (e.g., for issue #103382). The justification for re-enabling these tests, based on reverting PR #103071, lacks verification that the underlying flakiness has been resolved. This action violates the repository's explicit policy against re-enabling flaky tests without addressing their documented root causes, leading to potential CI instability and disruption of development workflows.

💡 Suggested Fix

Either provide concrete evidence and test results demonstrating that the root cause of flakiness for test_meta_accuracy and test_per_minute_formula has been resolved, or revert the changes that re-enable these tests until a verified fix is implemented.

🤖 Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location:
tests/snuba/api/endpoints/test_organization_events_stats_trace_metrics.py#L179-L180

Potential issue: The pull request re-enables `test_meta_accuracy` and
`test_per_minute_formula` which were previously marked as flaky (e.g., for issue
#103382). The justification for re-enabling these tests, based on reverting PR #103071,
lacks verification that the underlying flakiness has been resolved. This action violates
the repository's explicit policy against re-enabling flaky tests without addressing
their documented root causes, leading to potential CI instability and disruption of
development workflows.

Did we get this right? 👍 / 👎 to inform future reviews.

Reference_id: 2695588


Expand Down
1 change: 0 additions & 1 deletion tests/snuba/api/endpoints/test_organization_events_trace_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,6 @@ def test_sum_with_distribution_metric_type(self):
"sum(value, request_duration, distribution, -)": 155,
}

@pytest.mark.skip(reason="flaky: #103384")
def test_per_minute_formula(self) -> None:
# Store 6 trace metrics over a 10 minute period
self.store_trace_metrics(
Expand Down
Loading