Skip to content

Conversation

@Zylphrex
Copy link
Member

These tests failed because #103303 and #103071 were merged without being rebased on each other. #103071 has since been reverted.

Fixes #103382
Fixes #103384

These tests failed because #103303 and #103071 were merged without being rebased
on each other. #103071 has since been reverted.

Fixes #103382
Fixes #103384
@Zylphrex Zylphrex requested a review from a team as a code owner November 14, 2025 19:42
Comment on lines 179 to 180
def test_meta_accuracy(self):
metric_values = [1, 2, 3, 4]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Flaky tests test_meta_accuracy and test_per_minute_formula are re-enabled without verified root cause resolution.
Severity: HIGH | Confidence: 0.90

🔍 Detailed Analysis

The pull request re-enables test_meta_accuracy and test_per_minute_formula which were previously marked as flaky (e.g., for issue #103382). The justification for re-enabling these tests, based on reverting PR #103071, lacks verification that the underlying flakiness has been resolved. This action violates the repository's explicit policy against re-enabling flaky tests without addressing their documented root causes, leading to potential CI instability and disruption of development workflows.

💡 Suggested Fix

Either provide concrete evidence and test results demonstrating that the root cause of flakiness for test_meta_accuracy and test_per_minute_formula has been resolved, or revert the changes that re-enable these tests until a verified fix is implemented.

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location:
tests/snuba/api/endpoints/test_organization_events_stats_trace_metrics.py#L179-L180

Potential issue: The pull request re-enables `test_meta_accuracy` and
`test_per_minute_formula` which were previously marked as flaky (e.g., for issue
#103382). The justification for re-enabling these tests, based on reverting PR #103071,
lacks verification that the underlying flakiness has been resolved. This action violates
the repository's explicit policy against re-enabling flaky tests without addressing
their documented root causes, leading to potential CI instability and disruption of
development workflows.

Did we get this right? 👍 / 👎 to inform future reviews.

Reference_id: 2695588

@Zylphrex Zylphrex enabled auto-merge (squash) November 14, 2025 19:53
@Zylphrex Zylphrex merged commit 98e4dd5 into master Nov 14, 2025
63 checks passed
@Zylphrex Zylphrex deleted the txiao/test/re-enable-skipped-trace-metrics-tests branch November 14, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flaky test: test_per_minute_formula Flaky test: test_meta_accuracy

3 participants