feat(search-bar): Tweak logic category #103465
Merged
+13
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
approved these changes
Nov 18, 2025
Member
malwilley
left a comment
malwilley
left a comment
There was a problem hiding this comment.
I know it's not exactly valid, but IMO it would be a better experience if we just show all options all the time, so users understand what they are able to do
nsdeschenes
force-pushed
the
nd/feat-search-bar-tweak-logic-category-conditions
branch
from
ca8284b to
34fc3cd
Compare
nsdeschenes
deleted the
nd/feat-search-bar-tweak-logic-category-conditions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the logic category only renders when the filter item is not the first item in the search bar. This PR tweaks this to render the category, but with only the opening paren item, as it is the only valid one in that location.This PR removes the first item checks, and will display all logic operators at all times.