fix(timeseries): Handle orderbys not in groupby #103547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- If a field is in the orderby but not in the groupbys we currently error in snuba, this updates the resolver to add the orderby field to the groupbys automatically for both table/topEvents - Also fixes a bug where timeseries could be passed to the orderby, but we don't want that
github-actions
bot
added
the
Scope: Backend
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103547 +/- ##
============================================
+ Coverage 69.84% 80.68% +10.84%
============================================
Files 9268 9240 -28
Lines 395667 394785 -882
Branches 25217 25057 -160
============================================
+ Hits 276341 318522 +42181
+ Misses 118428 75815 -42613
+ Partials 898 448 -450 |
DominikB2014
approved these changes
Nov 19, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| if "timestamp" in raw_groupby: | ||
| raise ParseError("Cannot group by timestamp") | ||
| if raw_orderby: | ||
| if "timestamp" in [col.strip("-") for col in raw_orderby]: |
Contributor
There was a problem hiding this comment.
Bug: Incorrect use of strip instead of lstrip
The code uses strip("-") to remove the direction prefix from orderby columns, but this removes both leading and trailing hyphens. This differs from the standard pattern used throughout the codebase (like in rpc_dataset_common.py line 263) which uses lstrip("-") to only remove leading hyphens. If an orderby field name ends with a hyphen, strip would incorrectly remove it, causing the timestamp check to potentially fail or match the wrong field name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
error in snuba, but this updates the backend so we error instead so we can give the user a more friendly error message
we don't want that