Skip to content

feat(explore): Add saved queries to title for logs and metrics #103644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2025
Merged

feat(explore): Add saved queries to title for logs and metrics #103644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60fa790
:necktie: Add Traces to traces page title string
nsdeschenes Nov 19, 2025
de62336
:sparkles: Add in saved query title for metrics
nsdeschenes Nov 19, 2025
af21564
:sparkles: Add in saved query title for logs
nsdeschenes Nov 19, 2025
8cb1495
:recycle: Just use the string as the title as its only used for saved…
nsdeschenes Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions static/app/views/explore/logs/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ import useProjects from 'sentry/utils/useProjects';
import ExploreBreadcrumb from 'sentry/views/explore/components/breadcrumb';
import {LogsPageDataProvider} from 'sentry/views/explore/contexts/logs/logsPageData';
import {TraceItemAttributeProvider} from 'sentry/views/explore/contexts/traceItemAttributeContext';
import {useGetSavedQuery} from 'sentry/views/explore/hooks/useGetSavedQueries';
import {LogsTabOnboarding} from 'sentry/views/explore/logs/logsOnboarding';
import {LogsQueryParamsProvider} from 'sentry/views/explore/logs/logsQueryParamsProvider';
import {LogsTabContent} from 'sentry/views/explore/logs/logsTab';
Expand Down Expand Up @@ -109,9 +110,21 @@ export default function LogsContent() {
function LogsHeader() {
const pageId = useQueryParamsId();
const title = useQueryParamsTitle();
const organization = useOrganization();
const {data: savedQuery} = useGetSavedQuery(pageId);

const hasSavedQueryTitle =
defined(pageId) && defined(savedQuery) && savedQuery.name.length > 0;

return (
<Layout.Header unified>
<Layout.HeaderContent unified>
{hasSavedQueryTitle ? (
<SentryDocumentTitle
title={`${savedQuery.name} — ${t('Logs')}`}
orgSlug={organization?.slug}
/>
) : null}
{title && defined(pageId) ? (
<ExploreBreadcrumb traceItemDataset={TraceItemDataset.LOGS} />
) : null}
Expand Down
14 changes: 13 additions & 1 deletion static/app/views/explore/metrics/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {useFeedbackForm} from 'sentry/utils/useFeedbackForm';
import {useLocation} from 'sentry/utils/useLocation';
import useOrganization from 'sentry/utils/useOrganization';
import ExploreBreadcrumb from 'sentry/views/explore/components/breadcrumb';
import {useGetSavedQuery} from 'sentry/views/explore/hooks/useGetSavedQueries';
import {MetricsTabOnboarding} from 'sentry/views/explore/metrics/metricsOnboarding';
import {MetricsTabContent} from 'sentry/views/explore/metrics/metricsTab';
import {metricsPickableDays} from 'sentry/views/explore/metrics/utils';
Expand Down Expand Up @@ -92,13 +93,24 @@ function MetricsHeader() {
const location = useLocation();
const pageId = getIdFromLocation(location, ID_KEY);
const title = getTitleFromLocation(location, TITLE_KEY);
const organization = useOrganization();
const {data: savedQuery} = useGetSavedQuery(pageId);

const hasSavedQueryTitle =
defined(pageId) && defined(savedQuery) && savedQuery.name.length > 0;

return (
<Layout.Header unified>
<Layout.HeaderContent unified>
{hasSavedQueryTitle ? (
<SentryDocumentTitle
title={`${savedQuery.name} — ${t('Metrics')}`}
orgSlug={organization?.slug}
/>
) : null}
{title && defined(pageId) ? (
<ExploreBreadcrumb traceItemDataset={TraceItemDataset.TRACEMETRICS} />
) : null}

<Layout.Title>
{title ? title : t('Metrics')}
<FeatureBadge type="beta" />
Expand Down
5 changes: 4 additions & 1 deletion static/app/views/explore/spans/content.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,10 @@ function SpansTabHeader() {
<Layout.Header unified>
<Layout.HeaderContent unified>
{hasSavedQueryTitle ? (
<SentryDocumentTitle title={savedQuery.name} orgSlug={organization?.slug} />
<SentryDocumentTitle
title={`${savedQuery.name} — ${t('Traces')}`}
orgSlug={organization?.slug}
/>
) : null}
{title && defined(id) ? (
<ExploreBreadcrumb traceItemDataset={TraceItemDataset.SPANS} />
Expand Down
Loading