Skip to content

chore(checkout): Add path pattern #103668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2025
+3 −0
Merged

chore(checkout): Add path pattern #103668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7fc9d10
chore(checkout): Add path pattern
isabellaenriquez Nov 19, 2025
c66811d
add test
isabellaenriquez Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/organizations/absolute_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
re.compile(r"^\/?(?!settings)[^/]+\/([^/]+)\/getting-started\/(.*)"),
r"/getting-started/\1/\2",
),
(re.compile(r"^\/?checkout\/[^/]+\/(.*)"), r"/checkout/\1"),
Copy link
Contributor

@cursor cursor bot Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Checkout pattern misses paths without trailing slash

The checkout regex pattern requires a slash after the organization slug, so /checkout/acme (without trailing slash) won't match and won't be transformed, while /checkout/acme/ will transform to /checkout/. This creates inconsistent behavior. The pattern should use \/? instead of \/ before the capture group to handle both cases, similar to how the join-request pattern handles optional trailing slashes.

Fix in Cursor Fix in Web

Copy link
Member Author

@isabellaenriquez isabellaenriquez Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the slash is required, similar to onboarding

]


Expand Down
2 changes: 2 additions & 0 deletions tests/sentry/organizations/test_absolute_url.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@
("/join-request/acme/", "/join-request/"),
("/onboarding/acme/", "/onboarding/"),
("/onboarding/acme/project/", "/onboarding/project/"),
("/checkout/acme/", "/checkout/"),
("/checkout/acme/?query=value", "/checkout/?query=value"),
("/organizations/new/", "/organizations/new/"),
("/organizations/albertos-apples/issues/", "/issues/"),
("/organizations/albertos-apples/issues/?_q=all#hash", "/issues/?_q=all#hash"),
Expand Down
Loading