reducer: refactor complexity to On #103672
Merged
+40
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
natemoo-re
approved these changes
Nov 19, 2025
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
These all seem very reasonable!
TkDodo
approved these changes
Nov 20, 2025
Comment on lines
-151
to
+155
| // TODO: result.union(s) when Set.prototype.union is Baseline | ||
| // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Set/union | ||
| (result, s) => new Set([...result, ...s]), | ||
| new Set([]) | ||
| ); | ||
| return Object.values(TagFilterData).reduce<Set<string>>((acc, set) => { | ||
| for (const tag of set) { | ||
| acc.add(tag); | ||
| } | ||
| return acc; | ||
| }, new Set()); |
Collaborator
There was a problem hiding this comment.
looking at the comment: Set.union is baseline since June 2024. also we could probably run this once instead of having a function that does this?
export const sentryDefaultTags = Object.values(TagFilterData).reduce(
(result, s) => result.union(s),
new Set()
);
Member
Author
There was a problem hiding this comment.
I'm probably more conservative than I need to be here tbh, in part because I don't trust our tooling to tell me if this falls into our browserslist or not. Would be great to know if we should be seeing any warnings here or not
ryan953
pushed a commit
that referenced
this pull request
Dec 9, 2025
Refactor reducer spread or concat operations in a couple places where this might be sensitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor reducer spread or concat operations in a couple places where this might be sensitive