Skip to content

Conversation

@edwardgou-sentry
Copy link
Contributor

No longer prevent recording seer runs on Web Vital issues

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 19, 2025
@codecov
Copy link

codecov bot commented Nov 19, 2025

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
29887 2 29885 245
View the top 2 failed test(s) by shortest run time
tests.sentry.seer.autofix.test_autofix.TestTriggerAutofix::test_trigger_autofix_with_web_vitals_issue
Stack Traces | 4.33s run time
#x1B[1m#x1B[.../seer/autofix/test_autofix.py#x1B[0m:944: in test_trigger_autofix_with_web_vitals_issue
    mock_record_seer_run.assert_not_called()
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/unittest/mock.py#x1B[0m:938: in assert_not_called
    raise AssertionError(msg)
#x1B[1m#x1B[31mE   AssertionError: Expected 'record_seer_run' to not have been called. Called 1 times.#x1B[0m
#x1B[1m#x1B[31mE   Calls: [call(4557141412675584, 4557141412741120, <DataCategory.SEER_AUTOFIX: 27>)].#x1B[0m
tests.sentry.seer.autofix.test_issue_summary.IssueSummaryTest::test_get_issue_summary_with_web_vitals_issue
Stack Traces | 5.08s run time
#x1B[1m#x1B[.../seer/autofix/test_issue_summary.py#x1B[0m:610: in test_get_issue_summary_with_web_vitals_issue
    mock_record_seer_run.assert_not_called()
#x1B[1m#x1B[.../hostedtoolcache/Python/3.13.1.../x64/lib/python3.13/unittest/mock.py#x1B[0m:938: in assert_not_called
    raise AssertionError(msg)
#x1B[1m#x1B[31mE   AssertionError: Expected 'record_seer_run' to not have been called. Called 1 times.#x1B[0m
#x1B[1m#x1B[31mE   Calls: [call(4557141411692544, 4557141411692546, <DataCategory.SEER_SCANNER: 28>)].#x1B[0m

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review November 19, 2025 20:43
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner November 19, 2025 20:43
@edwardgou-sentry edwardgou-sentry requested a review from a team November 19, 2025 20:43
@edwardgou-sentry edwardgou-sentry merged commit a651e13 into master Nov 19, 2025
67 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/chore/wv-seer-runs-not-free branch November 19, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants