-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
fix(aci): remove email targetDisplay from UI POST request #103679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
malwilley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a test we can add to make sure this doesn't regress in the future?
| @@ -35,8 +35,18 @@ const stripSubfilterId = (subfilter: any) => { | |||
| return subfilterWithoutId; | |||
| }; | |||
|
|
|||
| const stripActionId = (action: any) => { | |||
| const stripActionFields = (action: any) => { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR, but we should really give action a type here
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
we use the targetDisplay to set automatic names for alerts (based on the configured actions), but the POST API doesn't expect a targetDisplay for email actions. this fix strips the targetDisplay field before submitting the form data.