test(issues): Migrate issue details components away from deprecatedRouterMocks #103699
+79
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
evanpurkhiser
approved these changes
Nov 20, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| it('can navigate next/previous events', async () => { | ||
| render(<IssueDetailsEventNavigation {...defaultProps} />, { | ||
| deprecatedRouterMocks: true, | ||
| initialRouterConfig: latestRouterConfig, |
Contributor
There was a problem hiding this comment.
Bug: Missing organization prop in render calls
The tests define an organization variable at the top level and use it to configure mock API responses in beforeEach, but don't pass it to the render() function. This causes the component to use a different organization instance created internally by initializeOrg(). While both have the same slug, this inconsistency could cause issues if organization objects are compared by reference or if other properties differ between instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.