fix(migrations): Fail migrations that delete models if no historical_silo_assignment is found #103702
+89
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
wedamija
pushed a commit
that referenced
this pull request
Nov 20, 2025
Deletes were silently failing if `historical_silo_assignments` wasn't updated. We prevent this from happening in #103702, and this cleans up the tables that should have already been removed
wedamija
force-pushed
the
danf/fail_model_deletion_without_assignment
branch
from
2aa0d6f to
fda420e
Compare
wedamija
added a commit
that referenced
this pull request
Nov 20, 2025
Deletes were silently failing if `historical_silo_assignments` wasn't updated. We prevent this from happening in #103702, and this cleans up the tables that should have already been removed fix lockfile
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #103702 +/- ##
===========================================
+ Coverage 80.45% 80.62% +0.17%
===========================================
Files 9278 9284 +6
Lines 396064 396333 +269
Branches 25247 25247
===========================================
+ Hits 318636 319536 +900
+ Misses 76968 76337 -631
Partials 460 460 |
armenzg
approved these changes
Nov 20, 2025
markstory
approved these changes
Nov 20, 2025
wedamija
force-pushed
the
danf/fail_model_deletion_without_assignment
branch
from
fda420e to
7d3fd48
Compare
wedamija
added a commit
that referenced
this pull request
Nov 20, 2025
Deletes were silently failing if `historical_silo_assignments` wasn't updated. We prevent this from happening in #103702, and this cleans up the tables that should have already been removed
…silo_assignment is found We have been silently failing the final deletion of tables for a while, because we need to add them to `historical_silo_assignments` for it to work correctly. This pr makes sure that we fail in CI if we aren't able to find an entry there.
wedamija
force-pushed
the
danf/fail_model_deletion_without_assignment
branch
from
7d3fd48 to
3d2ea92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been silently failing the final deletion of tables for a while, because we need to add them to
historical_silo_assignmentsfor it to work correctly. This pr makes sure that we fail in CI if we aren't able to find an entry there.