Skip to content

Conversation

@wedamija
Copy link
Member

Deletes were silently failing if historical_silo_assignments wasn't updated. We prevent this from happening in #103702, and this cleans up the tables that should have already been removed

@wedamija wedamija requested a review from a team as a code owner November 20, 2025 00:31
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 20, 2025
@github-actions
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/feedback/migrations/0007_cleanup_failed_safe_deletes.py src/sentry/migrations/1007_cleanup_failed_safe_deletes.py src/sentry/releases/migrations/0004_cleanup_failed_safe_deletes.py src/sentry/uptime/migrations/0049_cleanup_failed_safe_deletes.py src/sentry/workflow_engine/migrations/0102_cleanup_failed_safe_deletes.py

for 0007_cleanup_failed_safe_deletes in feedback

--
-- Raw SQL operation
--
DROP TABLE IF EXISTS feedback_feedback CASCADE;

for 1007_cleanup_failed_safe_deletes in sentry

--
-- Raw SQL operation
--
DROP TABLE IF EXISTS sentry_datasecrecywaiver CASCADE;
--
-- Raw SQL operation
--
DROP TABLE IF EXISTS sentry_dashboardwidgetsnapshot CASCADE;

for 0004_cleanup_failed_safe_deletes in releases

--
-- Raw SQL operation
--
DROP TABLE IF EXISTS releases_commit CASCADE;
--
-- Raw SQL operation
--
DROP TABLE IF EXISTS releases_commitfilechange CASCADE;

for 0049_cleanup_failed_safe_deletes in uptime

--
-- Raw SQL operation
--
DROP TABLE IF EXISTS uptime_projectuptimesubscription CASCADE;

for 0102_cleanup_failed_safe_deletes in workflow_engine

--
-- Raw SQL operation
--
DROP TABLE IF EXISTS workflow_engine_actiongroupstatus CASCADE;

Deletes were silently failing if `historical_silo_assignments` wasn't updated. We prevent this from happening in #103702, and this cleans up the tables that should have already been removed

fix lockfile
@wedamija wedamija merged commit f070b6f into master Nov 20, 2025
65 of 66 checks passed
@wedamija wedamija deleted the danf/cleanup-failed-table-deletes branch November 20, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants