-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(insights): Adds an endpoint to manually start issue detection task on a project #103760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
edwardgou-sentry
merged 3 commits into
master
from
egou/feat/add-wv-issue-detection-manual-endpoint
Nov 21, 2025
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| from rest_framework import status | ||
| from rest_framework.request import Request | ||
| from rest_framework.response import Response | ||
|
|
||
| from sentry.api.api_owners import ApiOwner | ||
| from sentry.api.api_publish_status import ApiPublishStatus | ||
| from sentry.api.base import region_silo_endpoint | ||
| from sentry.api.bases.project import ProjectEndpoint | ||
| from sentry.models.project import Project | ||
| from sentry.tasks.web_vitals_issue_detection import dispatch_detection_for_project_ids | ||
|
|
||
|
|
||
| @region_silo_endpoint | ||
| class ProjectWebVitalsDetectionEndpoint(ProjectEndpoint): | ||
| owner = ApiOwner.DATA_BROWSING | ||
| publish_status = { | ||
| "GET": ApiPublishStatus.PRIVATE, | ||
| } | ||
|
|
||
| def get(self, request: Request, project: Project) -> Response: | ||
| results = dispatch_detection_for_project_ids([project.id]) | ||
| if project.id not in results: | ||
| return Response({"status": "invalid_project"}, status=status.HTTP_400_BAD_REQUEST) | ||
| if results[project.id].get("success", False): | ||
| return Response({"status": "dispatched"}, status=status.HTTP_202_ACCEPTED) | ||
| return Response( | ||
| {"status": results[project.id].get("reason", "rejected")}, | ||
| status=status.HTTP_400_BAD_REQUEST, | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
tests/sentry/api/endpoints/test_project_web_vitals_detection.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| from unittest.mock import patch | ||
|
|
||
| from sentry.testutils.cases import APITestCase | ||
|
|
||
|
|
||
| class ProjectWebVitalsDetectionTest(APITestCase): | ||
| endpoint = "sentry-api-0-project-web-vitals-detection" | ||
| method = "get" | ||
|
|
||
| def setUp(self): | ||
| super().setUp() | ||
| self.login_as(user=self.user) | ||
|
|
||
| @patch("sentry.api.endpoints.project_web_vitals_detection.dispatch_detection_for_project_ids") | ||
| def test_get_success(self, mock_dispatch): | ||
| mock_dispatch.return_value = {self.project.id: {"success": True}} | ||
|
|
||
| response = self.get_success_response( | ||
| self.organization.slug, self.project.slug, status_code=202 | ||
| ) | ||
|
|
||
| assert response.status_code == 202 | ||
| assert response.data == {"status": "dispatched"} | ||
| mock_dispatch.assert_called_once_with([self.project.id]) | ||
|
|
||
| def test_get_requires_project_access(self): | ||
| other_user = self.create_user() | ||
| self.login_as(user=other_user) | ||
|
|
||
| response = self.get_error_response(self.organization.slug, self.project.slug) | ||
|
|
||
| assert response.status_code == 403 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edwardgou-sentry should we add better messaging on the not ok status? Bu t yeah can be done on a following PR.