Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ import {t} from 'sentry/locale';
import type {FeedbackIssue} from 'sentry/utils/feedback/types';
import useCopyToClipboard from 'sentry/utils/useCopyToClipboard';
import useOrganization from 'sentry/utils/useOrganization';
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';

interface Props {
feedbackItem: FeedbackIssue;
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/feedback/list/feedbackListItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import useReplayCountForFeedbacks from 'sentry/utils/replayCount/useReplayCountF
import useLocationQuery from 'sentry/utils/url/useLocationQuery';
import {useLocation} from 'sentry/utils/useLocation';
import useOrganization from 'sentry/utils/useOrganization';
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';

interface Props {
feedbackItem: FeedbackIssueListItem;
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/feedback/useDeleteFeedback.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import useApi from 'sentry/utils/useApi';
import {useLocation} from 'sentry/utils/useLocation';
import {useNavigate} from 'sentry/utils/useNavigate';
import useOrganization from 'sentry/utils/useOrganization';
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';

export const useDeleteFeedback = (feedbackIds: any, projectId: any) => {
const organization = useOrganization();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {decodeScalar} from 'sentry/utils/queryString';
import useLocationQuery from 'sentry/utils/url/useLocationQuery';
import {useNavigate} from 'sentry/utils/useNavigate';
import useOrganization from 'sentry/utils/useOrganization';
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';

export default function useRedirectToFeedbackFromEvent() {
const organization = useOrganization();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import type {ErrorFrame, FeedbackFrame, ReplayFrame} from 'sentry/utils/replays/
import {isErrorFrame, isFeedbackFrame} from 'sentry/utils/replays/types';
import useOrganization from 'sentry/utils/useOrganization';
import useProjectFromSlug from 'sentry/utils/useProjectFromSlug';
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';

interface Props {
frame: ReplayFrame;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {getMessage, getTitle} from 'sentry/utils/events';
import type {FeedbackIssue} from 'sentry/utils/feedback/types';
import {useApiQuery} from 'sentry/utils/queryClient';
import useOrganization from 'sentry/utils/useOrganization';
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';

type GroupHistory = {
count: number;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,21 +3,21 @@ import {ProjectFixture} from 'sentry-fixture/project';
import {act, render, screen} from 'sentry-test/reactTestingLibrary';

import ProjectsStore from 'sentry/stores/projectsStore';
import {UserFeedbackEmpty} from 'sentry/views/userFeedback/userFeedbackEmpty';
import {FeedbackEmptyState} from 'sentry/views/feedback/feedbackEmptyState';

describe('UserFeedbackEmpty', () => {
describe('FeedbackEmptyState', () => {
const project = ProjectFixture({id: '1'});
const projectWithReports = ProjectFixture({id: '2', hasUserReports: true});
const projectWithoutReports = ProjectFixture({id: '3'});

it('renders empty', () => {
render(<UserFeedbackEmpty />);
render(<FeedbackEmptyState />);
});

it('renders landing for project with no user feedback', () => {
act(() => ProjectsStore.loadInitialData([project]));

render(<UserFeedbackEmpty />);
render(<FeedbackEmptyState />);

expect(
screen.getByRole('heading', {name: 'What do users think?'})
Expand All @@ -27,7 +27,7 @@ describe('UserFeedbackEmpty', () => {
it('renders warning for project with any user feedback', () => {
act(() => ProjectsStore.loadInitialData([projectWithReports]));

render(<UserFeedbackEmpty />);
render(<FeedbackEmptyState />);

expect(
screen.getByText('Sorry, no user reports match your filters.')
Expand All @@ -37,7 +37,7 @@ describe('UserFeedbackEmpty', () => {
it('renders warning for projects with any user feedback', () => {
act(() => ProjectsStore.loadInitialData([project, projectWithReports]));

render(<UserFeedbackEmpty />);
render(<FeedbackEmptyState />);

expect(
screen.getByText('Sorry, no user reports match your filters.')
Expand All @@ -47,7 +47,7 @@ describe('UserFeedbackEmpty', () => {
it('renders warning for project query with user feedback', () => {
act(() => ProjectsStore.loadInitialData([project, projectWithReports]));

render(<UserFeedbackEmpty projectIds={[projectWithReports.id]} />);
render(<FeedbackEmptyState projectIds={[projectWithReports.id]} />);

expect(
screen.getByText('Sorry, no user reports match your filters.')
Expand All @@ -57,7 +57,7 @@ describe('UserFeedbackEmpty', () => {
it('renders landing for project query without any user feedback', () => {
act(() => ProjectsStore.loadInitialData([project, projectWithReports]));

render(<UserFeedbackEmpty projectIds={[project.id]} />);
render(<FeedbackEmptyState projectIds={[project.id]} />);

expect(
screen.getByRole('heading', {name: 'What do users think?'})
Expand All @@ -67,7 +67,7 @@ describe('UserFeedbackEmpty', () => {
it('renders warning for multi project query with any user feedback', () => {
act(() => ProjectsStore.loadInitialData([project, projectWithReports]));

render(<UserFeedbackEmpty projectIds={[project.id, projectWithReports.id]} />);
render(<FeedbackEmptyState projectIds={[project.id, projectWithReports.id]} />);

expect(
screen.getByText('Sorry, no user reports match your filters.')
Expand All @@ -77,7 +77,7 @@ describe('UserFeedbackEmpty', () => {
it('renders landing for multi project query without any user feedback', () => {
act(() => ProjectsStore.loadInitialData([project, projectWithoutReports]));

render(<UserFeedbackEmpty projectIds={[project.id, projectWithoutReports.id]} />);
render(<FeedbackEmptyState projectIds={[project.id, projectWithoutReports.id]} />);

expect(
screen.getByRole('heading', {name: 'What do users think?'})
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ type Props = {
projectIds?: string[];
};

export function UserFeedbackEmpty({projectIds, issueTab = false}: Props) {
export function FeedbackEmptyState({projectIds, issueTab = false}: Props) {
const {projects, initiallyLoaded} = useProjects();
const loadingProjects = !initiallyLoaded;
const organization = useOrganization();
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/issueDetails/groupUserFeedback.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@ import {space} from 'sentry/styles/space';
import {useLocation} from 'sentry/utils/useLocation';
import useOrganization from 'sentry/utils/useOrganization';
import {useParams} from 'sentry/utils/useParams';
import {FeedbackEmptyState} from 'sentry/views/feedback/feedbackEmptyState';
import {useGroup} from 'sentry/views/issueDetails/useGroup';
import {useGroupUserFeedback} from 'sentry/views/issueDetails/useGroupUserFeedback';
import {useHasStreamlinedUI} from 'sentry/views/issueDetails/utils';
import {UserFeedbackEmpty} from 'sentry/views/userFeedback/userFeedbackEmpty';

function GroupUserFeedback() {
const organization = useOrganization();
Expand Down Expand Up @@ -79,7 +79,7 @@ function GroupUserFeedback() {
</FilterMessage>
)}
{reportList.length === 0 ? (
<UserFeedbackEmpty projectIds={[group.project.id]} issueTab />
<FeedbackEmptyState projectIds={[group.project.id]} issueTab />
) : (
<Fragment>
{reportList.map((item, idx) => (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import type {Project} from 'sentry/types/project';
import normalizeUrl from 'sentry/utils/url/normalizeUrl';
import {formatVersion} from 'sentry/utils/versions/formatVersion';
import {makeDiscoverPathname} from 'sentry/views/discover/pathnames';
import {makeFeedbackPathname} from 'sentry/views/feedback/pathnames';
import type {
RoutableModuleNames,
URLBuilder,
Expand All @@ -27,7 +28,6 @@ import Tab from 'sentry/views/performance/transactionSummary/tabs';
import {getTransactionSummaryBaseUrl} from 'sentry/views/performance/transactionSummary/utils';
import {getPerformanceBaseUrl} from 'sentry/views/performance/utils';
import {makeTracesPathname} from 'sentry/views/traces/pathnames';
import {makeFeedbackPathname} from 'sentry/views/userFeedback/pathnames';

export enum TraceViewSources {
TRACES = 'traces',
Expand Down
Loading