fix(eap): Pass trace_item_type in RequestMeta for DeleteTraceItemsRequest RPC
#103784
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
nora-shap
approved these changes
Nov 20, 2025
shashjar
deleted the
pass-trace-item-type-in-delete-trace-items-request-meta
branch
Gust-feng
added a commit
to Gust-feng/sentry
that referenced
this pull request
Nov 21, 2025
…TraceItemsRequest` RPC (getsentry#103784)" This reverts commit 85d0f9f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another follow-up to #102808.
Fixes SENTRY-5DCB.
The
trace_item_typefield must be passed in both theTraceItemFilterWithTypeandRequestMetawhen issuing aDeleteTraceItemsRequestRPC. Previously, we were including this only in theTraceItemFilterWithType.