fix(explorer): accept trace id for flamegraph tool #103818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
JoshFerge
approved these changes
Nov 21, 2025
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #103818 +/- ##
===========================================
- Coverage 80.61% 80.61% -0.01%
===========================================
Files 9274 9281 +7
Lines 396025 396234 +209
Branches 25250 25250
===========================================
+ Hits 319274 319409 +135
- Misses 76291 76365 +74
Partials 460 460 |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
aliu39
approved these changes
Nov 22, 2025
| selected_thread_id = max(thread_in_app_counts.items(), key=lambda x: x[1])[0] | ||
| show_all_frames = False | ||
| else: | ||
| # No in_app frames found, try to find MainThread |
Member
There was a problem hiding this comment.
Did you mean to include these changes? Whats it for
Member
Author
There was a problem hiding this comment.
yeah just decided that we shouldn't be sending system-code profiles in any case (reverting recent change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds trace id as an extra optional filter to narrow down results, since profiler ids can span multiple traces.