fix(ui2): align OperationDot #103819
Merged
fix(ui2): align OperationDot #103819
+17
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
TkDodo
commented
Nov 21, 2025
TkDodo
commented
| before | after |
|---|---|
 |
 |
 |
 |
github-actions
bot
added
the
Scope: Frontend
TkDodo
commented
Nov 21, 2025
Comment on lines
+90
to
+93
| style={{ | ||
| borderRadius: isChonkTheme(theme) ? theme.radius.full : '100%', | ||
| backgroundColor, | ||
| }} |
Collaborator
Author
There was a problem hiding this comment.
@JonasBa I think we should at leat be able to apply borderRadius: 'full' - the value from our tokens - to Container
Regarding backgroundColor, not sure; it’s a value that comes from the color palette, so maybe inline style is fine?
Member
There was a problem hiding this comment.
Agree on radius="full" support!
On the background color, maybe we should add a separate fill prop that accepts graphics tokens? Currently the background prop expects background tokens.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
natemoo-re
approved these changes
Nov 21, 2025
Comment on lines
+90
to
+93
| style={{ | ||
| borderRadius: isChonkTheme(theme) ? theme.radius.full : '100%', | ||
| backgroundColor, | ||
| }} |
Member
There was a problem hiding this comment.
Agree on radius="full" support!
On the background color, maybe we should add a separate fill prop that accepts graphics tokens? Currently the background prop expects background tokens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.