Skip to content

feat(replay): Add sticky header support to replay table and header components #103825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 24, 2025
Merged

feat(replay): Add sticky header support to replay table and header components #103825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e5fa6ef
feat(replayTable): Add sticky header support to replay table and head…
jerryzhou196 Nov 21, 2025
6376b8e
fix(replayTableHeader): Update TableHeader component to support stick…
jerryzhou196 Nov 21, 2025
020c88f
ref(replayTableHeader): Simplify sticky header style implementation i…
jerryzhou196 Nov 21, 2025
c30733a
ref(replayTableHeader): Update header style type for improved type sa…
jerryzhou196 Nov 24, 2025
ac82fa8
docs(replayTable): Add comment clarifying stickyHeader functionality …
jerryzhou196 Nov 24, 2025
3d6a3ce
ref(replayTableHeader): Remove inline style from TableHeader for clea…
jerryzhou196 Nov 24, 2025
00939f5
ref(replayTableHeader): Explicitly define headerStyle type for better…
jerryzhou196 Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions static/app/components/replays/table/replayTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ type Props = SortProps & {
highlightedRowIndex?: number;
query?: Query;
ref?: RefObject<HTMLDivElement | null>;
stickyHeader?: boolean;
};

export default function ReplayTable({
Expand All @@ -43,6 +44,8 @@ export default function ReplayTable({
showDropdownFilters,
highlightedRowIndex = -1,
sort,
// stickyHeader only works if the table is inside a scrollable container
stickyHeader = false,
}: Props) {
const gridTemplateColumns = columns.map(col => col.width ?? 'max-content').join(' ');
const hasInteractiveColumn = columns.some(col => col.interactive);
Expand All @@ -59,6 +62,7 @@ export default function ReplayTable({
replays={replays}
onSortClick={onSortClick}
sort={sort}
stickyHeader={stickyHeader}
/>
<SimpleTable.Empty>
<LoadingIndicator />
Expand All @@ -79,6 +83,7 @@ export default function ReplayTable({
onSortClick={onSortClick}
replays={replays}
sort={sort}
stickyHeader={stickyHeader}
/>

<SimpleTable.Empty>
Expand All @@ -102,6 +107,7 @@ export default function ReplayTable({
onSortClick={onSortClick}
replays={replays}
sort={sort}
stickyHeader={stickyHeader}
/>
{replays.length === 0 && (
<SimpleTable.Empty>{t('No replays found')}</SimpleTable.Empty>
Expand Down
15 changes: 13 additions & 2 deletions static/app/components/replays/table/replayTableHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,18 +20,29 @@ type Props = {
replays: ReplayListRecord[];
onSortClick?: (key: string) => void;
sort?: Sort;
stickyHeader?: boolean;
};

export default function ReplayTableHeader({columns, replays, onSortClick, sort}: Props) {
export default function ReplayTableHeader({
columns,
replays,
onSortClick,
sort,
stickyHeader,
}: Props) {
const listItemCheckboxState = useListItemCheckboxContext();
const {countSelected, isAllSelected, isAnySelected, queryKey, selectAll, selectedIds} =
listItemCheckboxState;
const queryOptions = parseQueryKey(queryKey).options;
const queryString = queryOptions?.query?.query;

const headerStyle: React.CSSProperties = stickyHeader
? {position: 'sticky', top: 0}
: {};

return (
<Fragment>
<TableHeader>
<TableHeader style={headerStyle}>
{columns.map(({Header, sortKey}, columnIndex) => (
<SimpleTable.HeaderCell
key={`${sortKey}-${columnIndex}`}
Expand Down
1 change: 1 addition & 0 deletions static/app/views/replays/detail/playlist/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export default function Playlist() {
query={location.query}
replays={replays}
showDropdownFilters={false}
stickyHeader
/>
);
}
Loading