Skip to content

Conversation

@armenzg
Copy link
Member

@armenzg armenzg commented Nov 21, 2025

This helps with code consistency.

This helps with code consistency.
@armenzg armenzg requested a review from a team as a code owner November 21, 2025 18:29
@armenzg armenzg self-assigned this Nov 21, 2025
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 21, 2025

# Schedule a task per GROUP_CHUNK_SIZE batch of groups
for i in range(0, len(group_ids), GROUP_CHUNK_SIZE):
schedule_group_deletion_tasks(project.id, group_ids, transaction_id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we do anything with the number of scheduled tasks that comes back from this function? e.g. log or something else?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We track it as a metric here:

metrics.incr("delete_pending_groups.tasks_scheduled", amount=total_tasks, sample_rate=1.0)

@armenzg armenzg merged commit 1197cfa into master Nov 24, 2025
68 checks passed
@armenzg armenzg deleted the 11_21/minor_changes/armenzg branch November 24, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants