fix(aci): prevent deletion of system-created monitors in UI #103838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Member
|
we should probably do this in the api too, right? I can if you're not planning it. |
Member
Author
|
@kcons making the backend PR now! |
malwilley
approved these changes
Nov 21, 2025
scttcper
reviewed
Nov 21, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const [allInQuerySelected, setAllInQuerySelected] = useState(false); | ||
| const anySelected = selected.size > 0; | ||
|
|
||
| const canDelete = canEdit && !hasSystemCreatedDetectors; |
Contributor
There was a problem hiding this comment.
Bug: Delete enabled for query with system-created monitors
When using "Select all X monitors that match this search query", the canDelete check only considers system-created monitors on the current page. If the current page has only user-created monitors but other pages in the query results contain system-created monitors, the Delete button remains enabled. Clicking Delete would then attempt to delete all monitors matching the query, including system-created ones on other pages, bypassing the intended protection.
scttcper
approved these changes
Nov 21, 2025
ameliahsu
deleted the
mia/aci/fe-prevent-deleting-system-created-monitors
branch
ameliahsu
added a commit
that referenced
this pull request
Nov 24, 2025
system-created monitors should not be deleted by anyone, regardless of permissions backend fix to go with #103838 closes https://linear.app/getsentry/issue/NEW-646/prevent-api-from-deleting-error-monitor-detectors-via-bulk-edit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
system-created monitors should not be deleted by anyone, regardless of permissions
closes https://linear.app/getsentry/issue/NEW-647/disable-bulk-delete-in-ui-when-selection-includes-error-monitors